WebSocket Pepper API: add interfaces to handle binaryType attribute

WebSocket Pepper API: add interfaces to handle binaryType attribute

Add interfaces to handle binaryType attribute for various binary types supporting
in API version 0.9. Keeps the old interface as 0.1 for compatibility, and add
simple unit test just to instansiate the old interface.
Adding new interfaces are based on the WebSocket API.

BUG=87310
TEST=ui_test --gtest_filter='PPAPITest.WebSocket_*'

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117391

[Takashi Toyoshima, 2012-01-10 11:20:41]

A happy new year.
Could you review on WebSocket binding IDL?
Now, our bindings are going to support multiple binary data types.
So, I must define binary types handling API based on the WebSocket API.

I'm not sure about updating interface version.
I intend to define new API set as version 0.9 and keep old API set as version
0.1.

[dmichael (off chromium), 2012-01-11 04:53:41]

lgtm

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
File ppapi/api/dev/ppb_websocket_dev.idl (right):

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:58: PP_WEBSOCKETBINARYTYPE_INVALID = -1,
append _DEV

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:324: * SetBinaryType() specifies binary
object type for receiving binary frames
specifies "the" binary

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:328: * incoming binary frames as specified
binary object type.
as "the" specified

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:331: * of Blob bindings for Pepper.
I don't know if we should bother saying what type it "should" be based on the
spec. The default has to be ArrayBuffer for now, and assuming this API ships
before Blob support is added, we probably shouldn't ever change it.

So I think it should just say that the default is to use ArrayBuffer if this
function is not called.

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:339: * @return Returns <code>PP_FALSE</code>
if specified type is not supported.
if "the" specified

http://codereview.chromium.org/8989046/diff/4001/ppapi/tests/test_websocket.cc
File ppapi/tests/test_websocket.cc (right):

http://codereview.chromium.org/8989046/diff/4001/ppapi/tests/test_websocket.c...
ppapi/tests/test_websocket.cc:146:
pp::Module::Get()->GetBrowserInterface(PPB_WEBSOCKET_DEV_INTERFACE));
I don't think you really need to support backwards compatibility for this
interface yet, since it's still in Dev and as far as I know has no consumers.

http://codereview.chromium.org/8989046/diff/4001/ppapi/thunk/interfaces_ppb_p...
File ppapi/thunk/interfaces_ppb_public_dev.h (right):

http://codereview.chromium.org/8989046/diff/4001/ppapi/thunk/interfaces_ppb_p...
ppapi/thunk/interfaces_ppb_public_dev.h:68: PPB_WebSocket_Dev_0_9)
You can just replace the old interface in this case.

[Takashi Toyoshima, 2012-01-11 05:25:49]

Thank you for your review.

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
File ppapi/api/dev/ppb_websocket_dev.idl (right):

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:324: * SetBinaryType() specifies binary
object type for receiving binary frames
On 2012/01/11 04:53:41, dmichael wrote:
> specifies "the" binary

Done.

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:328: * incoming binary frames as specified
binary object type.
On 2012/01/11 04:53:41, dmichael wrote:
> as "the" specified

Done.

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:331: * of Blob bindings for Pepper.
I think it's confusing that the default binary type is different from JS API.
How about to say here,

Default type is PP_WEBSOCKETBINARYTYPE_BLOB_DEV.
Currently, Blob bindings is not supported in Pepper, so receiving binary type is
always ArrayBuffer.
To ensure backward compatibility, you must call this function with
PP_WEBSOCKETBINARYTYPE_ARRAYBUFFER_DEV to use binary frames.

http://codereview.chromium.org/8989046/diff/4001/ppapi/api/dev/ppb_websocket_...
ppapi/api/dev/ppb_websocket_dev.idl:339: * @return Returns <code>PP_FALSE</code>
if specified type is not supported.
On 2012/01/11 04:53:41, dmichael wrote:
> if "the" specified

Done.

http://codereview.chromium.org/8989046/diff/4001/ppapi/tests/test_websocket.cc
File ppapi/tests/test_websocket.cc (right):

http://codereview.chromium.org/8989046/diff/4001/ppapi/tests/test_websocket.c...
ppapi/tests/test_websocket.cc:146:
pp::Module::Get()->GetBrowserInterface(PPB_WEBSOCKET_DEV_INTERFACE));
OK, I remove this test.

http://codereview.chromium.org/8989046/diff/4001/ppapi/thunk/interfaces_ppb_p...
File ppapi/thunk/interfaces_ppb_public_dev.h (right):

http://codereview.chromium.org/8989046/diff/4001/ppapi/thunk/interfaces_ppb_p...
ppapi/thunk/interfaces_ppb_public_dev.h:68: PPB_WebSocket_Dev_0_9)
On 2012/01/11 04:53:41, dmichael wrote:
> You can just replace the old interface in this case.

Done.

[commit-bot: I haz the power, 2012-01-12 02:49:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8989046/5013

[commit-bot: I haz the power, 2012-01-12 07:03:53]

Change committed as 117391