Issue 8989035: CheckForNicePermission: Make sure can_reraise_priority is set in ctor

Issue 8989035: CheckForNicePermission: Make sure can_reraise_priority is set in ctor (Closed)

Created:
9 years ago by Tyler Breisacher (Chromium)

Modified:
9 years ago

Reviewers:
brettw, DaveMoore

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

CheckForNicePermission: Make sure can_reraise_priority is set in ctor CID=102592 BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115631

Patch Set 2 : move data to the bottom of the struct #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	base/process_linux.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/8989035/1

9 years ago (2011-12-22 20:07:00 UTC) #3

commit-bot: I haz the power

Presubmit check for 8989035-1 failed and returned exit status 1. Running presubmit commit checks ...

9 years ago (2011-12-22 20:07:02 UTC) #4

brettw

lgtm http://codereview.chromium.org/8989035/diff/1/base/process_linux.cc File base/process_linux.cc (right): http://codereview.chromium.org/8989035/diff/1/base/process_linux.cc#newcode110 base/process_linux.cc:110: bool can_reraise_priority; Normally data would appear at the ...

9 years ago (2011-12-22 20:10:46 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/8989035/5002

9 years ago (2011-12-22 20:25:37 UTC) #6

Change committed as 115631

Expand Messages | Collapse Messages