Update PPAPI IDL generator to define versioned structs, and unversioned typedef.

Update PPAPI IDL generator to define versioned structs, and unversioned typedef.

For interface Foo with versions A and B, structs will be defined for Foo_A and Foo_B, and a typedef generated from Foo_B to Foo.  Versioning of IDL structs remains unchanged.

(Follow-up to discussion on CL 8931019)

*** This change breaks compatibility with C code that makes use of unversioned-named interface structs. :( ***

We need to define a versioned-named struct for each interface's current version.  We could:

1.  Carry on defining the current struct unversioned and typedef a versioned name for it.
    The versioned type for the interface would be a typedef for the latest version and a struct for later versions, causing calling C code that uses it to break when a new version is added.

2.  Define structs for all versions, and a separate unversioned struct.
    This would lose type equivalence between the versioned and unversioned copies of the latest interface specification, and lead to needless duplication, especially for one-version interfaces.

3.  Do this CL.  We break some C code once, by change the unversioned type from struct to typedef, but we avoid these headaches in future.  C++ code shouldn't be affected.


*** Contents of this CL, including notes on to-dos:

This change requires updating thunk-getters to be defined using versioned names, so that the interface structs can be forward declared; the thunk-getters now have versioned names and return values.

Changing the thunk-getter naming requires updating unit-tests to call the versioned names.  It also requires some interface headers not generated from IDL to be manually updated to the new scheme (PPB_CharSet_Dev, PPB_Crypto_Dev, PPB_DirectoryReader_Dev, PPB_LayerCompositor_Dev, PPB_Graphics3D, PPB_Flash_Menu, PPB_Instance_Private, PPP_Pdf, PPB_Flash_NetConnector, PPB_GLESChromiumTextureMapping_Dev and PPB_Graphics3D_Trusted).

The proxy GetInfo() calls are updated to use versioned interface macros and thunks.  Similarly, most PPBs added in interface_list.cc are now added using versioned interface macros and thunk getters.  Ditto PluginModule, and some of PluginInstance.  Some implementations (e.g. PPB_CharSet_Dev) needed updating to use versioned thunk getters to fetch interfaces to use.

The VideoDecoder interface size checks are for 32-bit are updated not to expect structs.

It was necessary to replace forward declarations of interface structs with includes, and remove "struct" prefixes where unversioned names were used.  In most cases the affected code should really be updated to cope with versions.

PPP_Pdf has become PPP_Pdf_1.  Other versionless structs that should be updated for consistenct include PPB_UMA_Private, PPB_GPU_Blacklist_Private, PPB_Proxy_Private, PPP_PDF, PPB_OpenGLES2, PPB_Flash_File_FileRef and PPB_Flash_File_ModuleLocal.  Also PPP_Class_Deprecated, PPP_CursorControl_Dev, PPP_Find_Dev, PPP_NetworkState_Dev, PPP_Scrollbar_Dev, PPP_Selection_Dev, PPP_VideoCapture_Dev, PPP_Graphics3D and PPP_Instance_Private.

The Graphics2D and GLES2 examples now use unversioned interface type names without "struct" prefix.  It's not clear whether examples should use versioned names, to show best practice, or unversioned.

The typedef hack in PPP_Instance IDL is gone.  Yay.

BUG=107398, 108379
TEST=All Pepper and NaCl tests should continue to pass on Chromium bots.  NaCl SDK examples build correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116490

[Wez, 2011-12-20 02:06:59]

Apologies for the number of files this touches. :(

Most of the changes are required to cope with the idea that the standard API
"thunk" getter functions should always be versioned, not just track the latest
version.

[brettw, 2011-12-20 22:11:46]

lgtm

[noelallen1, 2011-12-20 22:33:31]

A few notes, otherwise LGTM

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/dev/ppb_gles_chromiu...
File ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h (right):

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/dev/ppb_gles_chromiu...
ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h:44: typedef
PPB_GLESChromiumTextureMapping_Dev_0_1
This is missing "struct"

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/private/ppb_instance...
File ppapi/c/private/ppb_instance_private.h (right):

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/private/ppb_instance...
ppapi/c/private/ppb_instance_private.h:76: #endif  /*
PPAPI_C_PRIVATE_PPB_INSTANCE_PRIVATE_H_ */
Missing blank line at EoF.

http://codereview.chromium.org/8989006/diff/6207/ppapi/proxy/ppb_flash_proxy.h
File ppapi/proxy/ppb_flash_proxy.h (right):

http://codereview.chromium.org/8989006/diff/6207/ppapi/proxy/ppb_flash_proxy....
ppapi/proxy/ppb_flash_proxy.h:36: static const PPB_Flash_12_0* GetInterface12();
_12_0 vs _11?

[Wez, 2011-12-21 01:15:51]

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/dev/ppb_gles_chromiu...
File ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h (right):

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/dev/ppb_gles_chromiu...
ppapi/c/dev/ppb_gles_chromium_texture_mapping_dev.h:44: typedef
PPB_GLESChromiumTextureMapping_Dev_0_1
On 2011/12/20 22:33:32, noelallen1 wrote:
> This is missing "struct"

Done.

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/private/ppb_instance...
File ppapi/c/private/ppb_instance_private.h (right):

http://codereview.chromium.org/8989006/diff/6207/ppapi/c/private/ppb_instance...
ppapi/c/private/ppb_instance_private.h:76: #endif  /*
PPAPI_C_PRIVATE_PPB_INSTANCE_PRIVATE_H_ */
On 2011/12/20 22:33:32, noelallen1 wrote:
> Missing blank line at EoF.

Done.

[commit-bot: I haz the power, 2011-12-22 02:16:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/11225

[commit-bot: I haz the power, 2011-12-22 02:17:12]

Can't apply patch for file ppapi/c/ppb_fullscreen.h.
While running patch -p1 --forward --force;
patching file ppapi/c/ppb_fullscreen.h
Hunk #1 FAILED at 3.
Hunk #2 succeeded at 33 with fuzz 2 (offset 6 lines).
Hunk #3 succeeded at 81 (offset 29 lines).
1 out of 3 hunks FAILED -- saving rejects to file ppapi/c/ppb_fullscreen.h.rej

[commit-bot: I haz the power, 2011-12-22 03:16:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/15001

[commit-bot: I haz the power, 2011-12-22 03:18:07]

Presubmit check for 8989006-15001 failed and returned exit status 1.

Running presubmit commit checks ...
  checking nsobjects took a long time: 639ms
  checking eol style took a long time: 619ms

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.h

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 24.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[dmichael (off chromium), 2011-12-22 20:14:57]

http://codereview.chromium.org/8989006/diff/17001/chrome/test/nacl_test_injec...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

http://codereview.chromium.org/8989006/diff/17001/chrome/test/nacl_test_injec...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:36:
tests_to_disable.append('run_earth_c')
Looking at native_client/tests/earth/nacl.scons, I think you need:
'earth_browser_test_c'
(and presumably 'earth_browser_test_cc')

[dmichael (off chromium), 2011-12-22 20:19:47]

As I mentioned in IM, you should probably update the native_client_sdk. I also
want note that this will break C source compatibility :-(. But I agree, we
probably need to bite the bullet now. Thanks for doing it.

And since commenting added me as a reviewer: LGTM

[yzshen1, 2011-12-23 00:16:11]

http://codereview.chromium.org/8989006/diff/21003/ppapi/proxy/ppb_url_loader_...
File ppapi/proxy/ppb_url_loader_proxy.h (right):

http://codereview.chromium.org/8989006/diff/21003/ppapi/proxy/ppb_url_loader_...
ppapi/proxy/ppb_url_loader_proxy.h:14: #include "ppapi/c/ppb_url_loader.h"
nit, optional: You could remove redundant headers from .cc file.
And other files have the same problem.

[Wez, 2012-01-03 13:06:58]

On 2011/12/22 20:19:47, dmichael wrote:
> As I mentioned in IM, you should probably update the native_client_sdk. I also
> want note that this will break C source compatibility :-(. But I agree, we
> probably need to bite the bullet now. Thanks for doing it.
> 
> And since commenting added me as a reviewer: LGTM

Done.

[Wez, 2012-01-03 13:11:08]

http://codereview.chromium.org/8989006/diff/21003/ppapi/proxy/ppb_url_loader_...
File ppapi/proxy/ppb_url_loader_proxy.h (right):

http://codereview.chromium.org/8989006/diff/21003/ppapi/proxy/ppb_url_loader_...
ppapi/proxy/ppb_url_loader_proxy.h:14: #include "ppapi/c/ppb_url_loader.h"
On 2011/12/23 00:16:11, yzshen1 wrote:
> nit, optional: You could remove redundant headers from .cc file.
> And other files have the same problem.

I think this is best left to a follow-up CL, but thanks for the suggestion.

[commit-bot: I haz the power, 2012-01-03 13:17:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/25001

[commit-bot: I haz the power, 2012-01-03 13:19:25]

Presubmit check for 8989006-25001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c \
  ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.h

License must match:
.*? Copyright \(c\) 2012 The Native Client Authors\. All rights reserved\.\n.*?
Use of this source code is governed by a BSD-style license that can be\n.*?
found in the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 15.8s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-01-03 14:31:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/25001

[commit-bot: I haz the power, 2012-01-03 14:32:55]

Presubmit check for 8989006-25001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c \
  ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.h

License must match:
.*? Copyright \(c\) 2012 The Native Client Authors\. All rights reserved\.\n.*?
Use of this source code is governed by a BSD-style license that can be\n.*?
found in the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 14.5s to calculate.

[commit-bot: I haz the power, 2012-01-03 16:36:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/25001

[commit-bot: I haz the power, 2012-01-03 16:38:27]

Presubmit check for 8989006-25001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c \
  ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.h

License must match:
.*? Copyright \(c\) 2012 The Native Client Authors\. All rights reserved\.\n.*?
Use of this source code is governed by a BSD-style license that can be\n.*?
found in the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 15.1s to calculate.

[commit-bot: I haz the power, 2012-01-03 17:56:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/25001

[commit-bot: I haz the power, 2012-01-03 17:57:21]

Can't apply patch for file ppapi/api/ppp_instance.idl.
While running patch -p1 --forward --force;
patching file ppapi/api/ppp_instance.idl
Hunk #1 FAILED at 216.
1 out of 1 hunk FAILED -- saving rejects to file ppapi/api/ppp_instance.idl.rej

[commit-bot: I haz the power, 2012-01-04 11:16:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/30001

[commit-bot: I haz the power, 2012-01-04 11:17:45]

Can't apply patch for file ppapi/c/ppb_view.h.
While running patch -p1 --forward --force;
patching file ppapi/c/ppb_view.h
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ppapi/c/ppb_view.h.rej

[commit-bot: I haz the power, 2012-01-04 14:18:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/35001

[commit-bot: I haz the power, 2012-01-04 14:20:24]

Presubmit check for 8989006-35001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.h

License must match:
.*? Copyright \(c\) 2012 The Native Client Authors\. All rights reserved\.\n.*?
Use of this source code is governed by a BSD-style license that can be\n.*?
found in the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppb_view.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 15.5s to calculate.

[commit-bot: I haz the power, 2012-01-04 14:33:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/33002

[commit-bot: I haz the power, 2012-01-04 14:35:00]

Presubmit check for 8989006-33002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.h

License must match:
.*? Copyright \(c\) 2012 The Native Client Authors\. All rights reserved\.\n.*?
Use of this source code is governed by a BSD-style license that can be\n.*?
found in the LICENSE file\.\n
Found a bad license header in these files:
  native_client_sdk/src/examples/hello_world_c/hello_world_c.c

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 14.9s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-01-04 14:46:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/41001

[commit-bot: I haz the power, 2012-01-04 14:47:53]

Presubmit check for 8989006-41001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.h

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 15.7s to calculate.

[commit-bot: I haz the power, 2012-01-04 15:35:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/39227

[commit-bot: I haz the power, 2012-01-04 15:38:24]

Presubmit check for 8989006-39227 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  ppapi/c/private/ppb_net_address_private.h, line 6, 81 chars \
  ppapi/c/trusted/ppb_audio_input_trusted_dev.h, line 6, 85 chars \
  ppapi/c/trusted/ppb_file_chooser_trusted.h, line 6, 82 chars

Missing matching PPAPI definition:

***************
  ppapi/api/dev/pp_video_capture_dev.idl
  ppapi/api/dev/pp_video_dev.idl
  ppapi/api/dev/ppb_audio_input_dev.idl
  ppapi/api/dev/ppb_buffer_dev.idl
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_console_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_cursor_control_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_file_chooser_dev.idl
  ppapi/api/dev/ppb_find_dev.idl
  ppapi/api/dev/ppb_font_dev.idl
  ppapi/api/dev/ppb_fullscreen_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_ime_input_event_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/dev/ppb_memory_dev.idl
  ppapi/api/dev/ppb_scrollbar_dev.idl
  ppapi/api/dev/ppb_testing_dev.idl
  ppapi/api/dev/ppb_text_input_dev.idl
  ppapi/api/dev/ppb_transport_dev.idl
  ppapi/api/dev/ppb_url_util_dev.idl
  ppapi/api/dev/ppb_var_array_buffer_dev.idl
  ppapi/api/dev/ppb_video_capture_dev.idl
  ppapi/api/dev/ppb_video_decoder_dev.idl
  ppapi/api/dev/ppb_video_layer_dev.idl
  ppapi/api/dev/ppb_websocket_dev.idl
  ppapi/api/dev/ppb_widget_dev.idl
  ppapi/api/dev/ppb_zoom_dev.idl
  ppapi/api/dev/ppp_printing_dev.idl
  ppapi/api/dev/ppp_video_decoder_dev.idl
  ppapi/api/dev/ppp_widget_dev.idl
  ppapi/api/dev/ppp_zoom_dev.idl
  ppapi/api/pp_completion_callback.idl
  ppapi/api/pp_file_info.idl
  ppapi/api/pp_input_event.idl
  ppapi/api/pp_point.idl
  ppapi/api/pp_rect.idl
  ppapi/api/pp_size.idl
  ppapi/api/pp_var.idl
  ppapi/api/ppb_audio.idl
  ppapi/api/ppb_audio_config.idl
  ppapi/api/ppb_core.idl
  ppapi/api/ppb_file_io.idl
  ppapi/api/ppb_file_ref.idl
  ppapi/api/ppb_file_system.idl
  ppapi/api/ppb_fullscreen.idl
  ppapi/api/ppb_graphics_2d.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/ppb_image_data.idl
  ppapi/api/ppb_input_event.idl
  ppapi/api/ppb_instance.idl
  ppapi/api/ppb_messaging.idl
  ppapi/api/ppb_mouse_lock.idl
  ppapi/api/ppb_url_loader.idl
  ppapi/api/ppb_url_request_info.idl
  ppapi/api/ppb_url_response_info.idl
  ppapi/api/ppb_var.idl
  ppapi/api/ppp_input_event.idl
  ppapi/api/ppp_messaging.idl
  ppapi/api/ppp_mouse_lock.idl
  ppapi/api/private/ppb_file_ref_private.idl
  ppapi/api/private/ppb_flash.idl
  ppapi/api/private/ppb_flash_clipboard.idl
  ppapi/api/private/ppb_flash_fullscreen.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_flash_tcp_socket.idl
  ppapi/api/private/ppb_flash_udp_socket.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/private/ppb_tcp_socket_private.idl
  ppapi/api/private/ppb_udp_socket_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_audio_trusted.idl
  ppapi/api/trusted/ppb_broker_trusted.idl
  ppapi/api/trusted/ppb_buffer_trusted.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_file_io_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
  ppapi/api/trusted/ppb_image_data_trusted.idl
  ppapi/api/trusted/ppb_url_loader_trusted.idl
***************

Presubmit checks took 16.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-01-05 11:24:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8989006/43001

[commit-bot: I haz the power, 2012-01-05 11:26:18]

Presubmit check for 8989006-43001 failed and returned exit status 1.

Running presubmit commit checks ...
  checking nsobjects took a long time: 830ms
  checking eol style took a long time: 579ms

** Presubmit Warnings **
Missing matching PPAPI definition:

***************
  ppapi/c/dev/pp_cursor_type_dev.h
  ppapi/c/pp_bool.h
  ppapi/c/pp_errors.h
  ppapi/c/pp_graphics_3d.h
  ppapi/c/pp_instance.h
  ppapi/c/pp_macros.h
  ppapi/c/pp_module.h
  ppapi/c/pp_resource.h
  ppapi/c/pp_stdint.h
  ppapi/c/pp_time.h
  ppapi/c/ppb.h
  ppapi/c/ppp.h
  ppapi/c/private/finish_writing_these/ppb_flash_file.h
  ppapi/c/private/finish_writing_these/ppb_flash_menu.h
  ppapi/c/private/finish_writing_these/ppb_nacl_private.h
  ppapi/c/private/finish_writing_these/ppb_pdf.h
  ppapi/c/private/finish_writing_these/ppb_proxy_private.h
  ppapi/c/trusted/ppp_broker.h
  ppapi/api/dev/ppb_char_set_dev.idl
  ppapi/api/dev/ppb_crypto_dev.idl
  ppapi/api/dev/ppb_directory_reader_dev.idl
  ppapi/api/dev/ppb_gles_chromium_texture_mapping_dev.idl
  ppapi/api/dev/ppb_layer_compositor_dev.idl
  ppapi/api/ppb_graphics_3d.idl
  ppapi/api/private/ppb_flash_menu.idl
  ppapi/api/private/ppb_flash_net_connector.idl
  ppapi/api/private/ppb_instance_private.idl
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
  ppapi/api/trusted/ppb_graphics_3d_trusted.idl
***************

Presubmit checks took 20.3s to calculate.