Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8985012: base::Bind: Convert net/proxy. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
csilv
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base::Bind: Convert net/proxy. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115068

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review and build fixes. #

Patch Set 3 : Pipelined even. #

Patch Set 4 : Clang. #

Patch Set 5 : Add bind includes. #

Total comments: 2

Patch Set 6 : One more include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -664 lines) Patch
M content/browser/resolve_proxy_msg_helper.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.h View 2 chunks +2 lines, -6 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 1 2 3 4 6 chunks +10 lines, -10 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.h View 2 chunks +3 lines, -5 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc View 1 2 3 4 9 chunks +14 lines, -15 lines 0 comments Download
M net/proxy/mock_proxy_resolver.h View 6 chunks +8 lines, -8 lines 0 comments Download
M net/proxy/mock_proxy_resolver.cc View 5 chunks +11 lines, -15 lines 0 comments Download
M net/proxy/mock_proxy_script_fetcher.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M net/proxy/mock_proxy_script_fetcher.cc View 1 2 3 3 chunks +9 lines, -8 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver.cc View 14 chunks +28 lines, -29 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 1 25 chunks +75 lines, -75 lines 0 comments Download
M net/proxy/network_delegate_error_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/network_delegate_error_observer_unittest.cc View 1 3 chunks +6 lines, -8 lines 0 comments Download
M net/proxy/polling_proxy_config_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_perftest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M net/proxy/proxy_resolver_v8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 19 chunks +48 lines, -48 lines 0 comments Download
M net/proxy/proxy_resolver_winhttp.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_winhttp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_script_decider.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/proxy/proxy_script_decider.cc View 1 2 3 4 7 chunks +14 lines, -13 lines 0 comments Download
M net/proxy/proxy_script_decider_unittest.cc View 1 2 3 4 5 19 chunks +43 lines, -38 lines 0 comments Download
M net/proxy/proxy_script_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl.h View 4 chunks +4 lines, -3 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 4 chunks +11 lines, -13 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 17 chunks +36 lines, -36 lines 0 comments Download
M net/proxy/proxy_service.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/proxy/proxy_service.cc View 21 chunks +31 lines, -102 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 1 53 chunks +166 lines, -144 lines 0 comments Download
M net/proxy/sync_host_resolver_bridge.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/proxy/sync_host_resolver_bridge_unittest.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M net/socket_stream/socket_stream.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Hawkins
9 years ago (2011-12-17 23:38:19 UTC) #1
James Hawkins
http://codereview.chromium.org/8985012/diff/1/net/proxy/mock_proxy_script_fetcher.h File net/proxy/mock_proxy_script_fetcher.h (right): http://codereview.chromium.org/8985012/diff/1/net/proxy/mock_proxy_script_fetcher.h#newcode28 net/proxy/mock_proxy_script_fetcher.h:28: const net::CompletionCallback& callback) OVERRIDE; Remove net:: here and below. ...
9 years ago (2011-12-17 23:50:55 UTC) #2
James Hawkins
http://codereview.chromium.org/8985012/diff/1/net/proxy/mock_proxy_script_fetcher.h File net/proxy/mock_proxy_script_fetcher.h (right): http://codereview.chromium.org/8985012/diff/1/net/proxy/mock_proxy_script_fetcher.h#newcode28 net/proxy/mock_proxy_script_fetcher.h:28: const net::CompletionCallback& callback) OVERRIDE; On 2011/12/17 23:50:55, James Hawkins ...
9 years ago (2011-12-18 00:05:47 UTC) #3
csilv
lgtm http://codereview.chromium.org/8985012/diff/17001/net/proxy/proxy_script_decider_unittest.cc File net/proxy/proxy_script_decider_unittest.cc (right): http://codereview.chromium.org/8985012/diff/17001/net/proxy/proxy_script_decider_unittest.cc#newcode6 net/proxy/proxy_script_decider_unittest.cc:6: #include "base/bind.h"
9 years ago (2011-12-20 01:05:13 UTC) #4
James Hawkins
9 years ago (2011-12-20 01:08:47 UTC) #5 
Going off the tryjobs of patch set 5 since I only added an include.

http://codereview.chromium.org/8985012/diff/17001/net/proxy/proxy_script_deci...
File net/proxy/proxy_script_decider_unittest.cc (right):

http://codereview.chromium.org/8985012/diff/17001/net/proxy/proxy_script_deci...
net/proxy/proxy_script_decider_unittest.cc:6: 
On 2011/12/20 01:05:13, csilv wrote:
> #include "base/bind.h"

Done.

Powered by Google App Engine
This is Rietveld 408576698