Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/renderer/extensions/schema_generated_bindings.cc

Issue 8985008: Don't use browser windows for platform app shell windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add view type, handle window closing. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_browser.gypi ('K') | « chrome/common/chrome_view_type.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/schema_generated_bindings.cc
diff --git a/chrome/renderer/extensions/schema_generated_bindings.cc b/chrome/renderer/extensions/schema_generated_bindings.cc
index a89c95fd49bcf9b5807de52b7ffdb9fec6427443..059a41d52b26bf51b01a598f0913c8ee85f1b9c6 100644
--- a/chrome/renderer/extensions/schema_generated_bindings.cc
+++ b/chrome/renderer/extensions/schema_generated_bindings.cc
@@ -276,6 +276,8 @@ class ExtensionImpl : public ChromeV8Extension {
view_type = chrome::VIEW_TYPE_EXTENSION_POPUP;
} else if (view_type_string == chrome::kViewTypeExtensionDialog) {
view_type = chrome::VIEW_TYPE_EXTENSION_DIALOG;
+ } else if (view_type_string == chrome::kViewTypeAppShell) {
+ view_type = chrome::VIEW_TYPE_APP_SHELL;
} else if (view_type_string != chrome::kViewTypeAll) {
return v8::Undefined();
}
« chrome/chrome_browser.gypi ('K') | « chrome/common/chrome_view_type.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698