Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5748)

Unified Diff: chrome/browser/extensions/extension_process_manager.cc

Issue 8985008: Don't use browser windows for platform app shell windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add view type, handle window closing. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager.cc
diff --git a/chrome/browser/extensions/extension_process_manager.cc b/chrome/browser/extensions/extension_process_manager.cc
index 33e92f308671bbb2df226bd88832745915393862..7579dd4f98639b5a08bf99e76074ce871de962c0 100644
--- a/chrome/browser/extensions/extension_process_manager.cc
+++ b/chrome/browser/extensions/extension_process_manager.cc
@@ -112,6 +112,19 @@ ExtensionProcessManager::~ExtensionProcessManager() {
DCHECK(background_hosts_.empty());
}
+ExtensionHost* ExtensionProcessManager::CreateShellHost(
+ const Extension* extension,
+ const GURL& url) {
+ DCHECK(extension);
+ ExtensionHost* host = new ExtensionHost(extension,
+ GetSiteInstanceForURL(url),
+ url,
+ chrome::VIEW_TYPE_APP_SHELL);
+ host->CreateView(NULL);
miket_OOO 2011/12/20 19:12:34 I wish ExtensionHost had something like CreateView
Mihai Parparita -not on Chrome 2012/01/04 22:46:46 Done.
+ OnExtensionHostCreated(host, false /* not a background host */);
+ return host;
+}
+
ExtensionHost* ExtensionProcessManager::CreateViewHost(
const Extension* extension,
const GURL& url,

Powered by Google App Engine
This is Rietveld 408576698