Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/ui/gtk/browser_titlebar.cc

Issue 8985008: Don't use browser windows for platform app shell windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add view type, handle window closing. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/browser_titlebar.h" 5 #include "chrome/browser/ui/gtk/browser_titlebar.h"
6 6
7 #include <gdk/gdkkeysyms.h> 7 #include <gdk/gdkkeysyms.h>
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 606 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 GdkPixbuf* icon_pixbuf = gfx::GdkPixbufFromSkBitmap(&icon); 617 GdkPixbuf* icon_pixbuf = gfx::GdkPixbufFromSkBitmap(&icon);
618 gtk_window_set_icon(window_, icon_pixbuf); 618 gtk_window_set_icon(window_, icon_pixbuf);
619 g_object_unref(icon_pixbuf); 619 g_object_unref(icon_pixbuf);
620 } 620 }
621 break; 621 break;
622 } 622 }
623 case Browser::TYPE_TABBED: { 623 case Browser::TYPE_TABBED: {
624 NOTREACHED() << "We should never have a tabbed app window."; 624 NOTREACHED() << "We should never have a tabbed app window.";
625 break; 625 break;
626 } 626 }
627 case Browser::TYPE_SHELL: {
628 // Shell windows don't show titles and icons for now.
629 break;
630 }
631 case Browser::TYPE_PANEL: { 627 case Browser::TYPE_PANEL: {
632 break; 628 break;
633 } 629 }
634 } 630 }
635 } 631 }
636 } 632 }
637 633
638 void BrowserTitlebar::UpdateThrobber(TabContents* tab_contents) { 634 void BrowserTitlebar::UpdateThrobber(TabContents* tab_contents) {
639 DCHECK(app_mode_favicon_); 635 DCHECK(app_mode_favicon_);
640 636
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 ui::SimpleMenuModel::Delegate* delegate) 1136 ui::SimpleMenuModel::Delegate* delegate)
1141 : SimpleMenuModel(delegate) { 1137 : SimpleMenuModel(delegate) {
1142 AddItemWithStringId(IDC_NEW_TAB, IDS_TAB_CXMENU_NEWTAB); 1138 AddItemWithStringId(IDC_NEW_TAB, IDS_TAB_CXMENU_NEWTAB);
1143 AddItemWithStringId(IDC_RESTORE_TAB, IDS_RESTORE_TAB); 1139 AddItemWithStringId(IDC_RESTORE_TAB, IDS_RESTORE_TAB);
1144 AddSeparator(); 1140 AddSeparator();
1145 AddItemWithStringId(IDC_TASK_MANAGER, IDS_TASK_MANAGER); 1141 AddItemWithStringId(IDC_TASK_MANAGER, IDS_TASK_MANAGER);
1146 AddSeparator(); 1142 AddSeparator();
1147 AddCheckItemWithStringId(kShowWindowDecorationsCommand, 1143 AddCheckItemWithStringId(kShowWindowDecorationsCommand,
1148 IDS_SHOW_WINDOW_DECORATIONS_MENU); 1144 IDS_SHOW_WINDOW_DECORATIONS_MENU);
1149 } 1145 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698