Refactoring of the client-side input pipeline and scaling dimension management.

remoting/client/plugin/pepper_view.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class is an implementation of the ChromotingView using Pepper devices
 // as the backing stores.  This class is used only on pepper thread.
 // Chromoting objects access this object through PepperViewProxy which
 // delegates method calls on the pepper thread.
 
 #ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
@@ skipping 24 matching lines @@
 
   // ChromotingView implementation.
   virtual bool Initialize() OVERRIDE;
   virtual void TearDown() OVERRIDE;
   virtual void Paint() OVERRIDE;
   virtual void SetSolidFill(uint32 color) OVERRIDE;
   virtual void UnsetSolidFill() OVERRIDE;
   virtual void SetConnectionState(
       protocol::ConnectionToHost::State state,
       protocol::ConnectionToHost::Error error) OVERRIDE;
-  virtual double GetHorizontalScaleRatio() const OVERRIDE;
-  virtual double GetVerticalScaleRatio() const OVERRIDE;
 
   // FrameConsumer implementation.
   virtual void AllocateFrame(media::VideoFrame::Format format,
                              const SkISize& size,
                              scoped_refptr<media::VideoFrame>* frame_out,
                              const base::Closure& done) OVERRIDE;
   virtual void ReleaseFrame(media::VideoFrame* frame) OVERRIDE;
   virtual void OnPartialFrameOutput(media::VideoFrame* frame,
                                     RectVector* rects,
                                     const base::Closure& done) OVERRIDE;
 
   // This is called when the dimension of the plugin element has changed.
   // Return true if plugin size has changed, false otherwise.
   bool SetPluginSize(const SkISize& plugin_size);
 
+  // Return the client view, and original host dimensions.
+  SkISize GetViewDimensions() const;

[Sergey Ulanov, 2011/12/20 00:05:35]

can this be inline view_dimentions()? Also, I think it's better to return const
reference here.

[Wez, 2011/12/20 07:14:14]

Done.

I've also renamed member |plugin_size_| to |view_size_| and SetPluginSize() to
SetViewSize().  I stopped short of going to set_view_size() and set_host_size()
on the basis that they're more than just setters; what do you think?

+  SkISize GetHostDimensions() const;
+
  private:
   void OnPaintDone(base::Time paint_start);
 
   // Set the dimension of the entire host screen.
   void SetHostSize(const SkISize& host_size);
 
   void PaintFrame(media::VideoFrame* frame, RectVector* rects);
 
   // Render the rectangle of |frame| to the backing store.
   // Returns true if this rectangle is not clipped.
@@ skipping 32 matching lines @@
   uint32 static_fill_color_;
 
   ScopedRunnableMethodFactory<PepperView> task_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperView);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_