Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Unified Diff: chrome/test/perf/page_cycler_test.cc

Issue 8984007: Revert 114929 - Standardize StringToInt{,64} interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome_frame/test/test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/page_cycler_test.cc
===================================================================
--- chrome/test/perf/page_cycler_test.cc (revision 114929)
+++ chrome/test/perf/page_cycler_test.cc (working copy)
@@ -9,7 +9,6 @@
#include "base/path_service.h"
#include "base/process_util.h"
#include "base/string_number_conversions.h"
-#include "base/string_piece.h"
#include "base/sys_string_conversions.h"
#include "base/test/test_timeouts.h"
#include "base/utf_string_conversions.h"
@@ -332,8 +331,8 @@
new_pos = timings.find(',', pos);
if (new_pos == std::string::npos)
new_pos = timings.length();
- if (!base::StringToInt(base::StringPiece(timings.begin() + pos,
- timings.begin() + new_pos),
+ if (!base::StringToInt(timings.begin() + pos,
+ timings.begin() + new_pos,
&time)) {
LOG(ERROR) << "Invalid time reported: " << time_str;
return true;
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome_frame/test/test_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698