Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 8984007: Revert 114929 - Standardize StringToInt{,64} interface. (Closed)

Created:
9 years ago by Ryan Sleevi
Modified:
9 years ago
Reviewers:
Ted Vessenes
CC:
chromium-reviews, jstritar+watch_chromium.org, cbentzel+watch_chromium.org, amit, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, robertshield, brettw-cc_chromium.org, darin-cc_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Revert 114929 - Standardize StringToInt{,64} interface. These changes address issue #106655. All variants of StringToInt have been converted to use the StringPiece class. One instance of conversion, in chrome/browser/history/text_database.cc, required copying an underlying string. This is because the string type in question could use 8 or 16 bit characters depending on the OS type, and because StringPiece is not implemented as a template, the code cannot specify whether to create a StringPiece or StringPiece16. This should be remedied in a future CL. R=erikwright@chromium.org BUG=106655 TEST= Review URL: http://codereview.chromium.org/8921006 TBR=tedvessenes@gmail.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -156 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M base/mac/mac_util.mm View 2 chunks +1 line, -4 lines 0 comments Download
M base/string_number_conversions.h View 3 chunks +32 lines, -6 lines 0 comments Download
M base/string_number_conversions.cc View 5 chunks +115 lines, -34 lines 0 comments Download
M base/string_number_conversions_unittest.cc View 6 chunks +90 lines, -0 lines 0 comments Download
M base/string_piece.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete_history_manager.cc View 2 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/history/text_database.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/filter_false_positive_perftest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/test/perf/page_cycler_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/test/test_server.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/utils.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/x509_cert_types.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_ctrl_response_buffer.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/ftp/ftp_util.cc View 3 chunks +12 lines, -15 lines 0 comments Download
M net/http/http_chunked_decoder.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/http/http_response_headers.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Sleevi
9 years ago (2011-12-17 21:57:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698