Issue 8984003: Port code generator to x64.

Issue 8984003: Port code generator to x64. (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Port code generator to x64. Committed: https://code.google.com/p/dart/source/detail?r=2557

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4902 lines, -112 lines)			Patch
M	runtime/lib/integers.cc	View	1 2	2 chunks	+21 lines, -11 lines	0 comments	Download
M	runtime/vm/assembler_macros_x64.cc	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1 2	4 chunks	+6 lines, -11 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2	7 chunks	+128 lines, -7 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 2	1 chunk	+80 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.h	View	1 2	3 chunks	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator_x64.h	View	1 2	2 chunks	+188 lines, -11 lines	0 comments	Download
A	runtime/vm/code_generator_x64.cc	View	1	1 chunk	+2797 lines, -0 lines	0 comments	Download
A	runtime/vm/code_generator_x64_test.cc	View		1 chunk	+500 lines, -0 lines	0 comments	Download
M	runtime/vm/code_index_table_test.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/code_patcher_x64.cc	View	1 2	1 chunk	+207 lines, -23 lines	0 comments	Download
A	runtime/vm/code_patcher_x64_test.cc	View		1 chunk	+86 lines, -0 lines	0 comments	Download
M	runtime/vm/compiler_test.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/constants_ia32.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/constants_x64.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_entry_test.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_test.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/stack_frame_x64.cc	View	1 2	2 chunks	+30 lines, -12 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	10 chunks	+10 lines, -11 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2	10 chunks	+815 lines, -7 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 2	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cshapiro

http://codereview.chromium.org/8984003/diff/1/runtime/lib/integers.cc File runtime/lib/integers.cc (right): http://codereview.chromium.org/8984003/diff/1/runtime/lib/integers.cc#newcode212 runtime/lib/integers.cc:212: return left.Value() + right.Value(); This needs an overflow check ...

9 years ago (2011-12-17 00:09:44 UTC) #2

regis

Thanks! http://codereview.chromium.org/8984003/diff/1/runtime/lib/integers.cc File runtime/lib/integers.cc (right): http://codereview.chromium.org/8984003/diff/1/runtime/lib/integers.cc#newcode212 runtime/lib/integers.cc:212: return left.Value() + right.Value(); On 2011/12/17 00:09:44, cshapiro ...

9 years ago (2011-12-17 00:47:43 UTC) #3

lgtm

Expand Messages | Collapse Messages