Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: runtime/vm/debugger.cc

Issue 8983034: Getting value of local variables on stack trace (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 3014)
+++ runtime/vm/debugger.cc (working copy)
@@ -166,8 +166,8 @@
intptr_t activation_token_pos = TokenIndex();
intptr_t desc_len = var_descriptors_->Length();
for (int i = 0; i < desc_len; i++) {
- intptr_t begin_pos, end_pos;
- var_descriptors_->GetRange(i, &begin_pos, &end_pos);
+ intptr_t scope_id, begin_pos, end_pos;
+ var_descriptors_->GetScopeInfo(i, &scope_id, &begin_pos, &end_pos);
if ((begin_pos <= activation_token_pos) &&
(activation_token_pos <= end_pos)) {
desc_indices_.Add(i);
@@ -193,18 +193,13 @@
ASSERT(name != NULL);
intptr_t desc_index = desc_indices_[i];
*name ^= var_descriptors_->GetName(desc_index);
- var_descriptors_->GetRange(i, token_pos, end_pos);
+ intptr_t scope_id;
+ var_descriptors_->GetScopeInfo(i, &scope_id, token_pos, end_pos);
ASSERT(value != NULL);
*value = GetLocalVarValue(var_descriptors_->GetSlotIndex(i));
}
-RawInstance* ActivationFrame::Value(const String& variable_name) {
- UNIMPLEMENTED();
- return NULL;
-}
-
-
const char* ActivationFrame::ToCString() {
const char* kFormat = "Function: '%s' url: '%s' line: %d";
« no previous file with comments | « runtime/vm/debugger.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698