build/common.gypi - Issue 8983031: clang: Remove -Wno-format now that our clang understands %as in c++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 8983031: clang: Remove -Wno-format now that our clang understands %as in c++. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 185866ea1f64670e49395b06c599f034533ba4b9..9d760d85f9845216382ffec97172a6a1693cc8aa 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1979,9 +1979,6 @@

# This (rightyfully) complains about 'override', which we use

# heavily.

'-Wno-c++11-extensions',

- # TODO(thakis): Reenable this once clang stops complaining about

- # %as in format strings.

- '-Wno-format',

'cflags!': [

# Clang doesn't seem to know know this flag.

« no previous file with comments | « no previous file | no next file » | no next file with comments »