Tweak the PPAPI IDL generator to wrap the generated-from comment if necessary.

Tweak the PPAPI IDL generator to wrap the generated-from comment if necessary.

BUG=109129
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116391

[Wez, 2012-01-04 16:26:34]

This just makes it possible to commit-queue changes involving long-named PPAPI
IDL files.  Specific things to review:

* Is there a better / more general comment-wrap system in the generator?
* Is the format of the newly-wrapped comments acceptable?

[dmichael (off chromium), 2012-01-04 16:42:24]

http://codereview.chromium.org/8983022/diff/1/ppapi/generators/idl_c_header.py
File ppapi/generators/idl_c_header.py (right):

http://codereview.chromium.org/8983022/diff/1/ppapi/generators/idl_c_header.p...
ppapi/generators/idl_c_header.py:142: out.Write('%s,\n *   %s\n\n' % (from_text,
modified_text))
So this won't handle if the first part (the file name) is already too long. But
I guess that's fine.
I think when C comments go multi-line elsewhere, we stick the closing "*/" on a
new line. I like the look of that better, if you don't mind

[dmichael (off chromium), 2012-01-04 16:54:36]

lgtm

[commit-bot: I haz the power, 2012-01-04 16:59:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8983022/2001

[commit-bot: I haz the power, 2012-01-04 17:00:03]

Presubmit check for 8983022-2001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
Missing matching PPAPI definition:

***************
  ppapi/api/private/ppb_net_address_private.idl
  ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
  ppapi/api/trusted/ppb_file_chooser_trusted.idl
***************

** Presubmit ERRORS **
PPAPI IDL Diff detected: Run the generator.

***************
--- OLD ../c/trusted/ppb_audio_input_trusted_dev.h 
+++ NEW ../c/trusted/ppb_audio_input_trusted_dev.h 
@@ -1,2 +1,2 @@
-/* Copyright (c) 2012 The Chromium Authors. All rights reserved.
+/* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
@@ -6,3 +6,3 @@
 /* From trusted/ppb_audio_input_trusted_dev.idl,
- *   modified Tue Jan  3 05:59:06 2012.
+ *   modified Mon Nov 21 14:43:42 2011.
  */
--- OLD ../c/trusted/ppb_file_chooser_trusted.h 
+++ NEW ../c/trusted/ppb_file_chooser_trusted.h 
@@ -1,2 +1,2 @@
-/* Copyright (c) 2012 The Chromium Authors. All rights reserved.
+/* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
@@ -6,3 +6,3 @@
 /* From trusted/ppb_file_chooser_trusted.idl,
- *   modified Tue Jan  3 05:59:06 2012.
+ *   modified Wed Oct 12 10:41:48 2011.
  */
--- OLD ../c/private/ppb_net_address_private.h 
+++ NEW ../c/private/ppb_net_address_private.h 
@@ -1,2 +1,2 @@
-/* Copyright (c) 2012 The Chromium Authors. All rights reserved.
+/* Copyright (c) 2011 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
@@ -6,3 +6,3 @@
 /* From private/ppb_net_address_private.idl,
- *   modified Tue Jan  3 05:59:06 2012.
+ *   modified Wed Nov  9 17:48:48 2011.
  */
Error C Header : Failed to generate range 0 : 6.
***************

Presubmit checks took 1.7s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[noelallen1, 2012-01-04 18:26:45]

LGTM

[commit-bot: I haz the power, 2012-01-04 18:27:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8983022/5006

[commit-bot: I haz the power, 2012-01-04 18:55:58]

Try job failure for 8983022-5006 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-01-04 19:00:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/8983022/5007

[commit-bot: I haz the power, 2012-01-04 21:57:06]

Change committed as 116391