Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: frog/lib/corelib_impl.dart

Issue 8983019: Native implementation of List,setRange for frog. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/lib/corelib_impl.dart
===================================================================
--- frog/lib/corelib_impl.dart (revision 2921)
+++ frog/lib/corelib_impl.dart (working copy)
@@ -72,7 +72,28 @@
List<E> getRange(int start, int length) native
"return this.slice(start, start + length);";
- void setRange(int start, int length, List<E> from, [int startFrom]) native;
+ void setRange(int start, int length, List<E> from, [int startFrom]) {
+ // length of 0 prevails and should not throw exceptions.
+ if (length == 0)
Jennifer Messerly 2012/01/05 17:59:33 style nit: we generally put these on one line, or
dominich 2012/01/05 18:19:57 Done.
+ return;
+
+ if (length < 0)
+ throw new IllegalArgumentException('length is negative in setRange');
+
+ if (start < 0)
+ throw new IndexOutOfRangeException(start);
+ if (start + length > this.length)
+ throw new IndexOutOfRangeException(start + length);
+ startFrom = (startFrom == null ? 0 : startFrom);
+ if (startFrom < 0)
+ throw new IndexOutOfRangeException(startFrom);
+ if (startFrom + length > from.length)
+ throw new IndexOutOfRangeException(startFrom + length);
+
+ for (var i = 0; i < length; ++i)
+ this[start + i] = from[startFrom + i];
+ }
+
void removeRange(int start, int length) native "this.splice(start, length);";
void insertRange(int start, int length, [E initialValue]) native
« no previous file with comments | « no previous file | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698