Native implementation of List,setRange for frog.

frog/lib/corelib_impl.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("dart:coreimpl");
 
 #source("../../corelib/src/implementation/dual_pivot_quicksort.dart");
 #source("../../corelib/src/implementation/duration_implementation.dart");
 #source("../../corelib/src/implementation/exceptions.dart");
 #source("../../corelib/src/implementation/future_implementation.dart");
@@ skipping 54 matching lines @@
   int lastIndexOf(E element, [int start]) native;
   void clear() { length = 0; }
 
   E removeLast() native "return this.pop();";
 
   E last() => this[this.length-1];
 
   List<E> getRange(int start, int length) native
     "return this.slice(start, start + length);";
 
-  void setRange(int start, int length, List<E> from, [int startFrom]) native;
+  void setRange(int start, int length, List<E> from, [int startFrom]) {

[sra1, 2012/01/05 18:38:44]

Can you do  [int startFrom = 0] ?

[dominich, 2012/01/05 18:53:21]

Done.

+    // length of 0 prevails and should not throw exceptions.
+    if (length == 0) return;
+    if (length < 0) throw new IllegalArgumentException('length is negative');
+
+    if (start < 0) throw new IndexOutOfRangeException(start);
+
+    int end = start + length;
+    if (end > this.length) throw new IndexOutOfRangeException(end);
+
+    startFrom = (startFrom == null ? 0 : startFrom);

[sra1, 2012/01/05 18:38:44]

This test would be unnecessary with the correct default value

[dominich, 2012/01/05 18:53:21]

Done.

+    if (startFrom < 0) throw new IndexOutOfRangeException(startFrom);
+
+    int endFrom = startFrom + length;
+    if (endFrom > from.length) throw new IndexOutOfRangeException(endFrom);
+
+    for (var i = 0; i < length; ++i)
+      this[start + i] = from[startFrom + i];
+  }
+
   void removeRange(int start, int length) native "this.splice(start, length);";
 
   void insertRange(int start, int length, [E initialValue]) native
     """
     // Splice in the values with a minimum of array allocations.
     var args = new Array(length + 2);
     args[0] = start;
     args[1] = 0;
     for (var i = 0; i < length; i++) {
       args[i + 2] = initialValue;
@@ skipping 361 matching lines @@
     } else if (isNaN()) {
       if (other.isNaN()) {
         return 0;
       }
       return 1;
     } else {
       return -1;
     }
   }
 }