Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 8983016: Fix a few preprocessor macros that could capture an 'else'. (Closed)

Created:
8 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
8 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix a few preprocessor macros that could capture an 'else'. Namely they are SLOW_ASSERT, RETURN_IF_SCHEDULED_EXCEPTION, and RETURN_IF_EMTPY_HANDLE_VALUE. R=svenpanne@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10329

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M src/checks.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/isolate.h View 1 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Chromium)
8 years, 11 months ago (2012-01-04 13:00:10 UTC) #1
Sven Panne
LGTM with nits http://codereview.chromium.org/8983016/diff/1/src/isolate.h File src/isolate.h (right): http://codereview.chromium.org/8983016/diff/1/src/isolate.h#newcode111 src/isolate.h:111: if (isolate->has_scheduled_exception()) { \ We should ...
8 years, 11 months ago (2012-01-04 13:19:48 UTC) #2
Kevin Millikin (Chromium)
Thanks for the comments. Please take another quick look.
8 years, 11 months ago (2012-01-04 13:52:03 UTC) #3
Sven Panne
8 years, 11 months ago (2012-01-04 14:24:41 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698