Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5840)

Unified Diff: chrome/browser/download/download_request_limiter.h

Issue 8983010: Convert WebContents to return a content::NavigationController instead of the implementation. Upda... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix mac Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_request_limiter.h
===================================================================
--- chrome/browser/download/download_request_limiter.h (revision 116232)
+++ chrome/browser/download/download_request_limiter.h (working copy)
@@ -15,11 +15,11 @@
#include "content/public/browser/notification_registrar.h"
class DownloadRequestInfoBarDelegate;
-class NavigationController;
class TabContents;
class TabContentsWrapper;
namespace content {
+class NavigationController;
class WebContents;
}
@@ -82,8 +82,8 @@
// is used. |originating_controller| is typically null, but differs from
// |controller| in the case of a constrained popup requesting the download.
TabDownloadState(DownloadRequestLimiter* host,
- NavigationController* controller,
- NavigationController* originating_controller);
+ content::NavigationController* controller,
+ content::NavigationController* originating_controller);
virtual ~TabDownloadState();
// Status of the download.
@@ -116,7 +116,7 @@
bool is_showing_prompt() const { return (infobar_ != NULL); }
// NavigationController we're tracking.
- NavigationController* controller() const { return controller_; }
+ content::NavigationController* controller() const { return controller_; }
// Invoked from DownloadRequestDialogDelegate. Notifies the delegates and
// changes the status appropriately. Virtual for testing.
@@ -145,7 +145,7 @@
DownloadRequestLimiter* host_;
- NavigationController* controller_;
+ content::NavigationController* controller_;
// Host of the first page the download started on. This may be empty.
std::string initial_page_host_;
@@ -215,8 +215,8 @@
// The returned TabDownloadState is owned by the DownloadRequestLimiter and
// deleted when no longer needed (the Remove method is invoked).
TabDownloadState* GetDownloadState(
- NavigationController* controller,
- NavigationController* originating_controller,
+ content::NavigationController* controller,
+ content::NavigationController* originating_controller,
bool create);
// CanDownloadOnIOThread invokes this on the UI thread. This determines the
@@ -248,7 +248,7 @@
// if the state is other than ALLOW_ONE_DOWNLOAD. Similarly once the state
// transitions from anything but ALLOW_ONE_DOWNLOAD back to ALLOW_ONE_DOWNLOAD
// the TabDownloadState is removed and deleted (by way of Remove).
- typedef std::map<NavigationController*, TabDownloadState*> StateMap;
+ typedef std::map<content::NavigationController*, TabDownloadState*> StateMap;
StateMap state_map_;
static TestingDelegate* delegate_;

Powered by Google App Engine
This is Rietveld 408576698