Allow targets to self-select optimization level in official builds.

build/internal/release_impl_official.gypi

Index: build/internal/release_impl_official.gypi
diff --git a/build/internal/release_impl_official.gypi b/build/internal/release_impl_official.gypi
index d62e955250c8d8c8b54d13d4a16b5aeb87e768e3..11b15cc4b7334ba1129a59b0e92343b2442cb997 100644
--- a/build/internal/release_impl_official.gypi
+++ b/build/internal/release_impl_official.gypi
@@ -1,3 +1,6 @@
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
 {
   'includes': ['release_defaults.gypi'],
   'defines': ['OFFICIAL_BUILD'],
@@ -9,15 +12,14 @@
       'FavorSizeOrSpeed': '2',
       'OmitFramePointers': 'true',
       'EnableFiberSafeOptimizations': 'true',
-      'WholeProgramOptimization': 'true',
     },
     'VCLibrarianTool': {
-      'AdditionalOptions': ['/ltcg', '/expectedoutputsize:120000000'],
+      'AdditionalOptions': [
+        '/ltcg',
+        '/expectedoutputsize:120000000'
+      ],
     },
     'VCLinkerTool': {

[bradn, 2011/12/16 23:44:45]

How about using target_conditions to inject this instead.
'target_defaults': [
  'variables': {
    'performance_critical%': 0,
  },
  'target_conditions': [
    'performance_critical==1', {
      'msvs_settings': {
        'VCCLCompilerTool': {'WholeProgramOptimization': 'true'},
     },
    },
  ],

Then each target can just add:
'performance_critical': 1, to the variable section or each target (or each
target_defaults in a gyp).
Two advantages:
- a clear way to inject into all the targets in a gyp file.
- no specific pathing to an include (allowing us to change things round).

-      # Get more debug spew from the linker while we're sorting out
-      # build problems and performance.
-      # TODO(siggi): Remove these flags after we're out of the woods.
       'AdditionalOptions': [
         '/time',
         # This may reduce memory fragmentation during linking.