Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered.

Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered.

BUG=108308, 108314
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115503

[dmichael (off chromium), 2011-12-20 23:52:26]

http://codereview.chromium.org/8982006/diff/6001/ppapi/cpp/var.cc
File ppapi/cpp/var.cc (right):

http://codereview.chromium.org/8982006/diff/6001/ppapi/cpp/var.cc#newcode216
ppapi/cpp/var.cc:216: snprintf(buf, sizeof(buf), "Var(UNDEFINED)");
The <> didn't play nicely when output as HTML. This isn't a huge deal, but it's
very helpful when there *are* leaks if the test framework can dump them.

http://codereview.chromium.org/8982006/diff/6001/ppapi/proxy/serialized_var.cc
File ppapi/proxy/serialized_var.cc (right):

http://codereview.chromium.org/8982006/diff/6001/ppapi/proxy/serialized_var.c...
ppapi/proxy/serialized_var.cc:418:
//serialized_[i].inner_->SetCleanupModeToEndReceiveCallerOwned();
Oops, meant to delete this. Is there a reason the destructor manually calls
EndReceiveCallerOwned? I think it would be more consistent with the rest of the
code to do what I have in this comment and have an empty destructor.

[brettw, 2011-12-21 00:31:42]

Sweet! LGTM

[dmichael (off chromium), 2011-12-21 00:32:20]

I sent this out a little prematurely. You can delay reviewing if you want.
On Dec 20, 2011 4:52 PM, <dmichael@chromium.org> wrote:

> Reviewers: brettw,
>
>
>
http://codereview.chromium.**org/8982006/diff/6001/ppapi/**cpp/var.cc<http://...
> File ppapi/cpp/var.cc (right):
>
> http://codereview.chromium.**org/8982006/diff/6001/ppapi/**
>
cpp/var.cc#newcode216<http://codereview.chromium.org/8982006/diff/6001/ppapi/cpp/var.cc#newcode216>
> ppapi/cpp/var.cc:216: snprintf(buf, sizeof(buf), "Var(UNDEFINED)");
> The <> didn't play nicely when output as HTML. This isn't a huge deal,
> but it's very helpful when there *are* leaks if the test framework can
> dump them.
>
> http://codereview.chromium.**org/8982006/diff/6001/ppapi/**
>
proxy/serialized_var.cc<http://codereview.chromium.org/8982006/diff/6001/ppapi/proxy/serialized_var.cc>
> File ppapi/proxy/serialized_var.cc (right):
>
> http://codereview.chromium.**org/8982006/diff/6001/ppapi/**
>
proxy/serialized_var.cc#**newcode418<http://codereview.chromium.org/8982006/diff/6001/ppapi/proxy/serialized_var.cc#newcode418>
> ppapi/proxy/serialized_var.cc:**418:
> //serialized_[i].inner_->**SetCleanupModeToEndReceiveCall**erOwned();
> Oops, meant to delete this. Is there a reason the destructor manually
> calls EndReceiveCallerOwned? I think it would be more consistent with
> the rest of the code to do what I have in this comment and have an empty
> destructor.
>
> Description:
> Add GetLiveVars to PPB_Testing_Dev. Fix leaks it uncovered.
>
> BUG=
> TEST=
>
>
> Please review this at
http://codereview.chromium.**org/8982006/<http://codereview.chromium.org/8982...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ppapi/api/dev/ppb_testing_dev.**idl
>  M ppapi/c/dev/ppb_testing_dev.h
>  M ppapi/cpp/dev/var_array_**buffer_dev.cc
>  M ppapi/cpp/var.cc
>  M ppapi/native_client/src/**shared/ppapi_proxy/browser_**
> ppb_messaging_rpc_server.cc
>  M ppapi/proxy/plugin_var_**serialization_rules.cc
>  M ppapi/proxy/ppb_testing_proxy.**cc
>  M ppapi/proxy/serialized_var.cc
>  M ppapi/proxy/serialized_var_**unittest.cc
>  M ppapi/shared_impl/var_tracker.**h
>  M ppapi/shared_impl/var_tracker.**cc
>  M ppapi/tests/test_case.h
>  M ppapi/tests/test_case.cc
>  M ppapi/tests/test_directory_**reader.cc
>  M ppapi/tests/test_file_io.cc
>  M ppapi/tests/test_file_ref.cc
>  M ppapi/tests/test_file_system.**cc
>  M ppapi/tests/test_flash_**fullscreen.cc
>  M ppapi/tests/test_fullscreen.cc
>  M ppapi/tests/test_graphics_2d.**cc
>  M ppapi/tests/test_graphics_3d.**cc
>  M ppapi/tests/test_input_event.**cc
>  M ppapi/tests/test_memory.cc
>  M ppapi/tests/test_post_message.**cc
>  M ppapi/tests/test_scrollbar.cc
>  M ppapi/tests/test_tcp_socket_**private_shared.cc
>  M ppapi/tests/test_transport.cc
>  M ppapi/tests/test_udp_socket_**private_shared.cc
>  M ppapi/tests/test_url_loader.cc
>  M ppapi/tests/test_var.cc
>  M ppapi/tests/test_var_**deprecated.cc
>  M ppapi/tests/test_video_**decoder.cc
>  M ppapi/tests/test_websocket.cc
>  M webkit/plugins/ppapi/message_**channel.cc
>  M webkit/plugins/ppapi/plugin_**module.cc
>
>
>

[commit-bot: I haz the power, 2011-12-21 17:47:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/8982006/18002

[commit-bot: I haz the power, 2011-12-21 18:19:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/8982006/18005

[commit-bot: I haz the power, 2011-12-21 20:34:49]

Try job failure for 8982006-18005 (retry) on mac_rel for steps "browser_tests,
ui_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-12-21 20:57:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/8982006/12006

[commit-bot: I haz the power, 2011-12-21 23:11:57]

Try job failure for 8982006-12006 (retry) (previous was lost) on linux_rel for
step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-21 23:32:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/8982006/12006

[commit-bot: I haz the power, 2011-12-22 08:35:54]

Change committed as 115503