Integrate HTMLMediaElement with Web Audio API's MediaElementAudioSourceNode

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 285 matching lines @@
     WebKit::WebMediaPlayerClient* client,
     base::WeakPtr<webkit_media::WebMediaPlayerDelegate> delegate,
     media::FilterCollection* collection,
     media::MessageLoopFactory* message_loop_factory,
     webkit_media::MediaStreamClient* media_stream_client,
     media::MediaLog* media_log,
     webkit_media::WebMediaPlayerImpl** player) {
   if (!prerender::PrerenderHelper::IsPrerendering(render_view))
     return false;
 
+  CommandLine* cmd = CommandLine::ForCurrentProcess();
+  bool disable_audio = cmd->HasSwitch(switches::kDisableAudio);

[acolwell GONE FROM CHROMIUM, 2011/12/22 17:43:27]

Hmm.. I was thinking that PrerenderWebMediaPlayer's caller would already have
CommandLine handling code. 

If you go up one more level you'll be in RenderViewImpl, but it looks like that
will trigger modifications to several other unrelated files. :(

How about we just put this back down in PrerenderWebMediaPlayer since there is
no real advantage to putting this code here. Sorry to go back and forth. I
should have done a little more research before the original suggestion.

[Chris Rogers, 2011/12/22 20:57:33]

Hi Aaron, sorry I'm not quite following you here.  Before in the previous
patch-set I wasn't even handling the command-line state and instead was passing
NULL (should have been false).  Can you be more specific about the exact code
change?  Thanks!

On 2011/12/22 17:43:27, acolwell wrote:

[acolwell GONE FROM CHROMIUM, 2011/12/22 21:48:49]

Sorry. Nevermind. This code is fine as is. I think I just confused myself when I
was swapping back and forth between source files during the review. 

   *player = new prerender::PrerenderWebMediaPlayer(render_view, client,
-      delegate, collection, message_loop_factory, media_stream_client,
-      media_log);
+      delegate, collection, disable_audio, message_loop_factory,
+      media_stream_client, media_log);
   return true;
 }
 
 WebPlugin* ChromeContentRendererClient::CreatePlugin(
     content::RenderView* render_view,
     WebFrame* frame,
     const WebPluginParams& original_params) {
   CommandLine* cmd = CommandLine::ForCurrentProcess();
   GURL url(original_params.url);
   std::string orig_mime_type = original_params.mimeType.utf8();
@@ skipping 491 matching lines @@
     webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) {
   factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory);
 }
 
 bool ChromeContentRendererClient::AllowSocketAPI(const GURL& url) {
   return allowed_socket_origins_.find(url.host()) !=
       allowed_socket_origins_.end();
 }
 
 }  // namespace chrome