Move indexeddb code to its own directory inside of content/{browser,common,renderer}

Move indexeddb code to its own directory inside of content/{browser,common,renderer}

BUG=105949
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115195

[dgrogan, 2011-12-16 23:08:21]

FYI for now.  Some of the includes are still out of order.

[jsbell, 2011-12-16 23:47:57]

LGTM except include order, as you noted.

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ind...
File content/renderer/indexed_db/indexed_db_dispatcher.cc (right):

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ind...
content/renderer/indexed_db/indexed_db_dispatcher.cc:12: #include
"content/renderer/indexed_db/renderer_webidbcursor_impl.h"
Nit: includes out of order

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
File content/renderer/indexed_db/renderer_webidbdatabase_impl.cc (right):

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
content/renderer/indexed_db/renderer_webidbdatabase_impl.cc:10: #include
"content/renderer/indexed_db/renderer_webidbobjectstore_impl.h"
Nit: Includes out of order

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
File content/renderer/indexed_db/renderer_webidbfactory_impl.cc (right):

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
content/renderer/indexed_db/renderer_webidbfactory_impl.cc:8: #include
"content/renderer/indexed_db/indexed_db_dispatcher.h"
Nit: includes out of order

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
File content/renderer/indexed_db/renderer_webidbindex_impl.cc (right):

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
content/renderer/indexed_db/renderer_webidbindex_impl.cc:10: #include
"content/renderer/indexed_db/renderer_webidbtransaction_impl.h"
Nit: includes out of order

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
File content/renderer/indexed_db/renderer_webidbobjectstore_impl.cc (right):

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
content/renderer/indexed_db/renderer_webidbobjectstore_impl.cc:9: #include
"content/renderer/indexed_db/indexed_db_dispatcher.h"
Nit: includes out of order

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
File content/renderer/indexed_db/renderer_webidbtransaction_impl.cc (right):

http://codereview.chromium.org/8980002/diff/1/content/renderer/indexed_db/ren...
content/renderer/indexed_db/renderer_webidbtransaction_impl.cc:8: #include
"content/renderer/indexed_db/indexed_db_dispatcher.h"
Nit: includes out of order

[hans, 2011-12-19 14:12:06]

Awesome! It will be very nice to have this landed.

[dgrogan, 2011-12-19 20:00:51]

John, could you review this?

[jam, 2011-12-19 23:23:30]

lgtm with nits

what about content/browser/in_process_webkit/indexed_db*, shouldn't these move
into content/browser/indexed_db?

http://codereview.chromium.org/8980002/diff/7001/content/common/indexed_db/in...
File content/common/indexed_db/indexed_db_key.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/common/indexed_db/in...
content/common/indexed_db/indexed_db_key.h:5: #ifndef
CONTENT_COMMON_INDEXED_DB_KEY_H_
nit: update include guard

http://codereview.chromium.org/8980002/diff/7001/content/common/indexed_db/in...
File content/common/indexed_db/indexed_db_param_traits.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/common/indexed_db/in...
content/common/indexed_db/indexed_db_param_traits.h:5: #ifndef
CONTENT_COMMON_INDEXED_DB_PARAM_TRAITS_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/indexed_db_dispatcher.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/indexed_db_dispatcher.h:5: #ifndef
CONTENT_RENDERER_INDEXED_DB_DISPATCHER_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/indexed_db_message_filter.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/indexed_db_message_filter.h:5: #ifndef
CONTENT_RENDERER_INDEXED_DB_MESSAGE_FILTER_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/renderer_webidbcursor_impl.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/renderer_webidbcursor_impl.h:5: #ifndef
CONTENT_RENDERER_RENDERER_WEBIDBCURSOR_IMPL_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/renderer_webidbdatabase_impl.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/renderer_webidbdatabase_impl.h:5: #ifndef
CONTENT_RENDERER_RENDERER_WEBIDBDATABASE_IMPL_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/renderer_webidbfactory_impl.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/renderer_webidbfactory_impl.h:5: #ifndef
CONTENT_RENDERER_RENDERER_WEBIDBFACTORY_IMPL_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/renderer_webidbindex_impl.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/renderer_webidbindex_impl.h:5: #ifndef
CONTENT_RENDERER_RENDERER_WEBIDBINDEX_IMPL_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/renderer_webidbobjectstore_impl.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/renderer_webidbobjectstore_impl.h:5: #ifndef
CONTENT_RENDERER_RENDERER_WEBIDBOBJECTSTORE_IMPL_H_
ditto

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
File content/renderer/indexed_db/renderer_webidbtransaction_impl.h (right):

http://codereview.chromium.org/8980002/diff/7001/content/renderer/indexed_db/...
content/renderer/indexed_db/renderer_webidbtransaction_impl.h:5: #ifndef
CONTENT_RENDERER_RENDERER_WEBIDBTRANSACTION_IMPL_H_
ditto

[dgrogan, 2011-12-19 23:56:04]

> what about content/browser/in_process_webkit/indexed_db*, shouldn't these move
> into content/browser/indexed_db?

We talked about that but weren't sure.  How much info is conveyed by residing in
the in_process_webkit directory?  I definitely think they should be moved to
content/browser/indexed_db when the code no longer requires running on the
webkit thread.

WDYT?

[jam, 2011-12-20 02:51:18]

On 2011/12/19 23:56:04, dgrogan wrote:
> > what about content/browser/in_process_webkit/indexed_db*, shouldn't these
move
> > into content/browser/indexed_db?
> 
> We talked about that but weren't sure.  How much info is conveyed by residing
in
> the in_process_webkit directory?  I definitely think they should be moved to
> content/browser/indexed_db when the code no longer requires running on the
> webkit thread.
> 
> WDYT?

sure that sounds reasonable

[commit-bot: I haz the power, 2011-12-20 18:05:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/8980002/16001

[commit-bot: I haz the power, 2011-12-20 19:32:15]

Try job failure for 8980002-16001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-20 20:15:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgrogan@chromium.org/8980002/19003

[commit-bot: I haz the power, 2011-12-20 22:04:31]

Change committed as 115195