Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: chrome/browser/ui/panels/panel_browser_view.cc

Issue 8979001: Merge 113553 - Hide panels in presence of full screen app for windows. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/963/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_view.h ('k') | chrome/browser/ui/panels/panel_browser_window_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_browser_view.cc
===================================================================
--- chrome/browser/ui/panels/panel_browser_view.cc (revision 114830)
+++ chrome/browser/ui/panels/panel_browser_view.cc (working copy)
@@ -100,6 +100,16 @@
l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
}
+void PanelBrowserView::Show() {
+ if (!panel_->manager()->is_full_screen())
+ BrowserView::Show();
+}
+
+void PanelBrowserView::ShowInactive() {
+ if (!panel_->manager()->is_full_screen())
+ BrowserView::ShowInactive();
+}
+
void PanelBrowserView::Close() {
GetWidget()->RemoveObserver(this);
closed_ = true;
@@ -413,11 +423,13 @@
}
void PanelBrowserView::FullScreenModeChanged(bool is_full_screen) {
- // TODO(prasadt): Enable this code.
- // if (is_full_screen)
- // HideThePanel.
- // else
- // ShowThePanel.
+ if (is_full_screen) {
+ if (frame()->IsVisible()) {
+ frame()->Hide();
+ }
+ } else {
+ ShowInactive();
+ }
}
void PanelBrowserView::HandlePanelKeyboardEvent(
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_view.h ('k') | chrome/browser/ui/panels/panel_browser_window_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698