Issue 8976007: Really add test Origin Bound Certificate data for http://codereview.chromium.org/8890073/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8976007: Really add test Origin Bound Certificate data for http://codereview.chromium.org/8890073/ (Closed)

Created:
9 years ago by mattm

Modified:
9 years ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Really add test Origin Bound Certificate data for http://codereview.chromium.org/8890073/ (Failed to add by commit queue in r114525) BUG=107047 TEST=none TBR=wtc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114750

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-2 lines, --2 lines)			Patch
	M	net/data/ssl/certificates/unittest.originbound.der	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	M	net/data/ssl/certificates/unittest.originbound.key.der	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

9 years ago (2011-12-16 18:50:58 UTC) #2

LGTM.

In the future you can add test certificates as PEM files.
The openssl tool has options to include a "pretty printed"
version of the certificate before the base64-encoded
CERTIFICATE block.

I believe we can also import private keys in PEM format.

Expand Messages | Collapse Messages