Extensions: send the whole manifest to the extensions process in

Extensions: send the whole manifest to the extensions process in
ExtensionMsg_Loaded_Params, rather than cherry-picking the desired values,
avoiding widespread confusion.


BUG=
TEST=browser_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114785

[Aaron Boodman, 2011-12-16 06:44:22]

http://codereview.chromium.org/8976003/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension_messages.h (left):

http://codereview.chromium.org/8976003/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension_messages.h:100: struct
ExtensionMsg_Loaded_Params {
Can you find the call site and filter out extension->is_theme()? We never need
those in renderers, so it's just extra IPC traffic and memory for no reasons.
And the theme manifests can be large.

[not at google - send to devlin, 2011-12-16 07:07:45]

Running the theme change through the trybots now.  Heading home now so didn't
put much thought into the change beyond wrapping them in "if (!theme)".

http://codereview.chromium.org/8976003/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension_messages.h (left):

http://codereview.chromium.org/8976003/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension_messages.h:100: struct
ExtensionMsg_Loaded_Params {
On 2011/12/16 06:44:23, Aaron Boodman wrote:
> Can you find the call site and filter out extension->is_theme()? We never need
> those in renderers, so it's just extra IPC traffic and memory for no reasons.
> And the theme manifests can be large.

Done.

[Aaron Boodman, 2011-12-16 07:31:00]

LGTM, thanks for this cleanup.

[commit-bot: I haz the power, 2011-12-16 08:42:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/8976003/8002

[commit-bot: I haz the power, 2011-12-16 09:57:52]

Change committed as 114785