Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 8975001: Pepper: Change '*_sources' variables in ppapi_sources.gypi to '*_source_files'. (Closed)

Created:
9 years ago by viettrungluu
Modified:
9 years ago
Reviewers:
brettw, noelallen1
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Change '*_sources' variables in ppapi_sources.gypi to '*_source_files'. This makes gyp properly relativize the paths; see <http://code.google.com/p/gyp/wiki/InputFormatReference#Pathname_Relativization>;. TEST=builds + trybots TBR=noelallen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114751

Patch Set 1 #

Patch Set 2 : fix nacl? #

Patch Set 3 : yanaclf #

Patch Set 4 : argh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M native_client_sdk/src/build_tools/build.scons View 1 2 chunks +6 lines, -5 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi/build.scons View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi/nacl.scons View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_cpp.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 6 chunks +7 lines, -7 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_untrusted.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
viettrungluu
9 years ago (2011-12-15 21:48:47 UTC) #1
viettrungluu
+noelallen for NaCl-related changes
9 years ago (2011-12-15 21:50:20 UTC) #2
brettw
lgtm
9 years ago (2011-12-15 22:12:25 UTC) #3
viettrungluu
noelallen -> TBR (I think it's okay despite apparent try failures)
9 years ago (2011-12-16 01:10:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8975001/9002
9 years ago (2011-12-16 01:11:03 UTC) #5
noelallen1
lgtm
9 years ago (2011-12-16 01:17:37 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-16 02:30:12 UTC) #7
Change committed as 114751

Powered by Google App Engine
This is Rietveld 408576698