Resolve initializers in constructors.

frog/leg/warnings.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class MessageKind {
   final String template;
   const MessageKind(this.template);
 
   static final GENERIC = const MessageKind('#{1}');
 
   static final NOT_ASSIGNABLE = const MessageKind(
       '#{2} is not assignable to #{1}');
   static final VOID_EXPRESSION = const MessageKind(
       'expression does not yield a value');
   static final VOID_VARIABLE = const MessageKind(
       'variable cannot be of type void');
   static final RETURN_VALUE_IN_VOID = const MessageKind(
       'cannot return value from void function');
   static final RETURN_NOTHING = const MessageKind(
       'value of type #{1} expected');
   static final MISSING_ARGUMENT = const MessageKind(
       'missing argument of type #{1}');
   static final ADDITIONAL_ARGUMENT = const MessageKind(
       'additional argument');
   static final METHOD_NOT_FOUND = const MessageKind(
       'no method named #{2} in class #{1}');
   static final MEMBER_NOT_STATIC = const MessageKind(
       '#{1}.#{2} is not static');
+  static final NOT_STATIC = const MessageKind(
+      '#{1} is not static');
 
   static final UNREACHABLE_CODE = const MessageKind(
       'unreachable code');
   static final MISSING_RETURN = const MessageKind(
       'missing return');
   static final MAYBE_MISSING_RETURN = const MessageKind(
       'not all paths lead to a return or throw statement');
 
   static final CANNOT_RESOLVE = const MessageKind(
       'cannot resolve #{1}');
   static final CANNOT_RESOLVE_TYPE = const MessageKind(
       'cannot resolve type #{1}');
   static final DUPLICATE_DEFINITION = const MessageKind(
       'duplicate definition of #{1}');
   static final NOT_A_TYPE = const MessageKind(
       '#{1} is not a type');
   static final CANNOT_FIND_CONSTRUCTOR = const MessageKind(
       'cannot find constructor #{1}');
+  static final INVALID_RECEIVER_IN_INITIALIZER = const MessageKind(
+      'field initializer expected');
+  static final DUPLICATE_INITIALIZER = const MessageKind(
+      'field #{1} is initialized more than once (before at #{2})');

[ngeoffray, 2011/12/21 11:52:11]

before at -> already initialized at ?

[ahe, 2011/12/21 12:01:58]

I'm not sure I understand this. Won't it just say:

"field foo is initialized more than once (before at foo)"

I would think there should be a diagnostic for each "duplicated" initializer.

[karlklose, 2011/12/21 16:33:46]

Removed 'before at' in favor of a second warning.

[karlklose, 2011/12/21 16:33:46]

No, it would print the initializer node. I removed it and print another warning
now.

+  static final INIT_STATIC_FIELD = const MessageKind(
+      'cannot initialize static field #{1}');
+  static final NOT_A_FIELD = const MessageKind(
+      '#{1} is not a field');
 
   toString() => template;
 }
 
 class Message {
   final kind;
   final List arguments;
   String message;
 
   Message(this.kind, this.arguments);
@@ skipping 32 matching lines @@
   String toString() => message.toString();
 }
 
 class ResolutionWarning {
   final Message message;
   ResolutionWarning.message(this.message);
   ResolutionWarning(MessageKind kind, List<Type> arguments)
     : message = new Message(kind, arguments);
   String toString() => message.toString();
 }