Issue 8974009: Fix bug with filtering of foreign context maps in the type feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8974009: Fix bug with filtering of foreign context maps in the type feedback. (Closed)

Created:
9 years ago by fschneider

Modified:
9 years ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix bug with filtering of foreign context maps in the type feedback. The first attempt did not properly handle keyed loads/stores and did not check the constructors of the objects in the prototype chain. Added two more tests to handle the fixed cases. BUG=v8:1823 TEST=LeakGlobalObjectViaMapKeyed,LeakGlobalContextViaMapProto Committed: http://code.google.com/p/v8/source/detail?r=10277

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+117 lines, -24 lines)			Patch
M	src/type-info.cc	View	7 chunks	+37 lines, -18 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	5 chunks	+80 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages