Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 8972010: Introduce AddMediaTests factory method. (Closed)

Created:
9 years ago by DaleCurtis
Modified:
8 years, 11 months ago
Reviewers:
cmp, Nirnimesh
CC:
chromium-reviews, Nicolas Sylvain, imasaki1, shadi
Visibility:
Public.

Description

Introduce AddMediaTests factory method. As titled, introduces a new AddMediaTests factory method which will eventually become the home for all media tests. None of the existing tests are actually working right now, so I've decided to bite the bullet and drop them all now. We'll focus on fixing these next quarter. BUG=106257, 106260 TEST=Ran local buildbot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115223

Patch Set 1 #

Patch Set 2 : Make generic. #

Patch Set 3 : Go for gold. #

Total comments: 3

Patch Set 4 : Code review fixes. #

Patch Set 5 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -291 lines) Patch
M scripts/master/factory/chromium_commands.py View 1 2 3 4 4 chunks +47 lines, -273 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 2 4 chunks +10 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
DaleCurtis
9 years ago (2011-12-16 20:41:44 UTC) #1
DaleCurtis
Comments from imasaki and nirnimesh convinced me to switch to using pyauto_functional --suite instead of ...
9 years ago (2011-12-16 22:20:22 UTC) #2
Nirnimesh
http://codereview.chromium.org/8972010/diff/5001/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (left): http://codereview.chromium.org/8972010/diff/5001/scripts/master/factory/chromium_commands.py#oldcode651 scripts/master/factory/chromium_commands.py:651: env={'PYTHONPATH': '.'}, I think this is needed for QA ...
9 years ago (2011-12-20 00:34:43 UTC) #3
DaleCurtis
http://codereview.chromium.org/8972010/diff/5001/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (right): http://codereview.chromium.org/8972010/diff/5001/scripts/master/factory/chromium_commands.py#newcode619 scripts/master/factory/chromium_commands.py:619: workdir: the working dir for this step On 2011/12/20 ...
9 years ago (2011-12-20 22:42:42 UTC) #4
Nirnimesh
LGTM
9 years ago (2011-12-20 23:02:29 UTC) #5
cmp
lgtm
9 years ago (2011-12-20 23:22:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/8972010/13001
9 years ago (2011-12-20 23:26:47 UTC) #7
commit-bot: I haz the power
Change committed as 115223
9 years ago (2011-12-20 23:29:48 UTC) #8
Nirnimesh
On 2011/12/20 23:29:48, I haz the power (commit-bot) wrote: > Change committed as 115223 I'm ...
8 years, 12 months ago (2011-12-28 22:28:10 UTC) #9
DaleCurtis
8 years, 11 months ago (2012-01-03 18:32:09 UTC) #10
Ugh, sorry about that. It was using runtest on my local machine. I suspect
something odd with the linux vs linux2 checks. The checks between what PyAuto
wants and WebDriver wants appear mutually exclusive, so I'll just revert my
attempt at creating a common Python test method. New CL will be up shortly.


On 2011/12/28 22:28:10, Nirnimesh wrote:
> On 2011/12/20 23:29:48, I haz the power (commit-bot) wrote:
> > Change committed as 115223
> 
> I'm going to have to revert this because it causes the QA waterfall to fail.
> 
>
http://chrome-master2.mtv.corp.google.com:8011/builders/Chrome%2520Win%2520XP...
> 
> Besides, it's also not using runtest.py for win and linux.

Powered by Google App Engine
This is Rietveld 408576698