Chromium Code Reviews| Index: tools/testing/perf_testing/create_graph.py |
| =================================================================== |
| --- tools/testing/perf_testing/create_graph.py (revision 2456) |
| +++ tools/testing/perf_testing/create_graph.py (working copy) |
| @@ -57,7 +57,8 @@ |
| out = subprocess.PIPE |
| if outfile: |
| mode = 'w' |
| - if append: |
| + if append |
|
Siggi Cherem (dart-lang)
2011/12/16 00:24:32
I believe the : should stay on this line?
|
| + # On Windows, shell must be true to get the correct environment variables.: |
| mode = 'a' |
| out = open(outfile, mode) |
| p = subprocess.Popen(cmd_list, stdout = out, stderr = subprocess.PIPE) |
| @@ -589,8 +590,7 @@ |
| RunCmd(['echo', '%f Compiling on Dart VM in production mode in seconds' |
| % elapsed], self.trace_file, append=True) |
| elapsed = TimeCmd([os.path.join('.', 'minfrog'), '--out=minfrog', |
| - '--warnings_as_errors', 'minfrog.dart', os.path.join('tests', |
| - 'hello.dart')]) |
| + 'minfrog.dart', os.path.join('tests', 'hello.dart')]) |
| if elapsed < self.failure_threshold['Bootstrapping']: |
| #minfrog didn't compile correctly. Stop testing now, because subsequent |
| #numbers will be meaningless. |