Switch from the benighted PlatformThread to the shiny SimpleThread

Switch from the benighted PlatformThread to the shiny SimpleThread
Also add a comment to explain the strange tls gyrations in
SlotReturnFunction.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4481

[dank, 2008-10-31 20:19:04]

Here y'go.

[Dean McNamee, 2008-10-31 20:30:20]

Thanks.  LGTM with the changes.

http://codereview.chromium.org/8972/diff/202/204
File base/stats_table.cc (right):

http://codereview.chromium.org/8972/diff/202/204#newcode349
Line 349: // on some platforms as already cleared the TLS
typo.  Plus, your comment line are really short, you can
make the 80 char, it will look at a lot nicer.

http://codereview.chromium.org/8972/diff/202/204#newcode350
Line 350: // info.  To be portable, must use the tls_data
XXX must use, this sentence doesn't read right.

http://codereview.chromium.org/8972/diff/202/203
File base/stats_table_unittest.cc (right):

http://codereview.chromium.org/8972/diff/202/203#newcode74
Line 74: base::SimpleThread(name), id_(id) { };
This goes on the same line as the :

No ; at the end, this is a definition.

http://codereview.chromium.org/8972/diff/202/203#newcode117
Line 117: StatsTableThread *threads[kMaxThreads];
* is on the wrong place, goes on the type.