Issue 8970002: Revert 114680 - Remove FRIEND_TEST declarations to improve optimizations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8970002: Revert 114680 - Remove FRIEND_TEST declarations to improve optimizations (Closed)

Created:
9 years ago by jar (doing other things)

Modified:
9 years ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 114680 - Remove FRIEND_TEST declarations to improve optimizations Friends may access methods that are otherwise unused. Removing friends may cause dead-code elimination, and also reduce the need for copies of entry points (allowing more inlining). r=laforge TBR=jar@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114682

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -13 lines)			Patch
	M	base/json/json_reader.h	View		1 chunk	+2 lines, -13 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages