Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 8969024: Make sure the Autolaunch infobar... (Closed)

Created:
9 years ago by Finnur
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make sure the Autolaunch infobar... 1) shows up on First Run of Chrome (for the right experiment brand code). 2) takes precedent over the 'Chrome is not your default browser' infobar. 3) is not shown if other infobars are present. Also some minor cleanup: - Renamed IsInAutoLaunchGroup to IsInAutoLaunchFieldTrial (better fit). - Moved brand specific code to auto_launch_trial namespace (easier to find) and created meaningful function names for'em. BUG=106801 TEST=This requires a special branded build (see instructions for http://codereview.chromium.org/8729009). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114974

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -21 lines) Patch
M chrome/browser/auto_launch_trial.h View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/auto_launch_trial.cc View 2 chunks +10 lines, -1 line 1 comment Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_init.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 4 chunks +22 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
Care for some minor polish?
9 years ago (2011-12-16 16:48:50 UTC) #1
Roger Tawa OOO till Jul 10th
9 years ago (2011-12-16 20:44:31 UTC) #2
lgtm

http://codereview.chromium.org/8969024/diff/1/chrome/browser/auto_launch_tria...
File chrome/browser/auto_launch_trial.cc (right):

http://codereview.chromium.org/8969024/diff/1/chrome/browser/auto_launch_tria...
chrome/browser/auto_launch_trial.cc:21: bool IsInAutoLaunchFieldTrial() {
I actually think the old name was better.  Remember that the control group *is*
in the field trial; they just happen to be ones not getting the extra goodies. 
They are different from the "rest of the population" since the rest is not being
tracked with user metrics.

Powered by Google App Engine
This is Rietveld 408576698