Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: chrome/browser/ui/gtk/view_id_util_browsertest.cc

Issue 8968039: Remove outdated // TODO. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <gtk/gtk.h> 5 #include <gtk/gtk.h>
6 6
7 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/browser_window.h" 8 #include "chrome/browser/ui/browser_window.h"
9 #include "chrome/browser/ui/gtk/view_id_util.h" 9 #include "chrome/browser/ui/gtk/view_id_util.h"
10 #include "chrome/common/url_constants.h" 10 #include "chrome/common/url_constants.h"
(...skipping 20 matching lines...) Expand all
31 31
32 IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) { 32 IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) {
33 // Make sure FindBar is created to test 33 // Make sure FindBar is created to test
34 // VIEW_ID_FIND_IN_PAGE_TEXT_FIELD and VIEW_ID_FIND_IN_PAGE. 34 // VIEW_ID_FIND_IN_PAGE_TEXT_FIELD and VIEW_ID_FIND_IN_PAGE.
35 browser()->ShowFindBar(); 35 browser()->ShowFindBar();
36 36
37 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) { 37 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
38 // The following ids are used only in views implementation. 38 // The following ids are used only in views implementation.
39 if (i == VIEW_ID_CONTENTS_SPLIT || 39 if (i == VIEW_ID_CONTENTS_SPLIT ||
40 i == VIEW_ID_INFO_BAR_CONTAINER || 40 i == VIEW_ID_INFO_BAR_CONTAINER ||
41 i == VIEW_ID_DEV_TOOLS_DOCKED || // TODO(pfeldman): verify it is Ok 41 i == VIEW_ID_DEV_TOOLS_DOCKED ||
42 i == VIEW_ID_DOWNLOAD_SHELF || 42 i == VIEW_ID_DOWNLOAD_SHELF ||
43 i == VIEW_ID_BOOKMARK_BAR_ELEMENT || 43 i == VIEW_ID_BOOKMARK_BAR_ELEMENT ||
44 i == VIEW_ID_TAB || 44 i == VIEW_ID_TAB ||
45 i == VIEW_ID_SIDE_BAR_CONTAINER || 45 i == VIEW_ID_SIDE_BAR_CONTAINER ||
46 i == VIEW_ID_SIDE_BAR_SPLIT || 46 i == VIEW_ID_SIDE_BAR_SPLIT ||
47 i == VIEW_ID_FEEDBACK_BUTTON || 47 i == VIEW_ID_FEEDBACK_BUTTON ||
48 i == VIEW_ID_OMNIBOX) { 48 i == VIEW_ID_OMNIBOX) {
49 continue; 49 continue;
50 } 50 }
51 51
52 CheckViewID(static_cast<ViewID>(i), true); 52 CheckViewID(static_cast<ViewID>(i), true);
53 } 53 }
54 54
55 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false); 55 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);
56 } 56 }
57 57
58 IN_PROC_BROWSER_TEST_F(ViewIDTest, Delegate) { 58 IN_PROC_BROWSER_TEST_F(ViewIDTest, Delegate) {
59 CheckViewID(VIEW_ID_TAB_0, true); 59 CheckViewID(VIEW_ID_TAB_0, true);
60 CheckViewID(VIEW_ID_TAB_1, false); 60 CheckViewID(VIEW_ID_TAB_1, false);
61 61
62 browser()->OpenURL(OpenURLParams(GURL(chrome::kAboutBlankURL), 62 browser()->OpenURL(OpenURLParams(GURL(chrome::kAboutBlankURL),
63 content::Referrer(), 63 content::Referrer(),
64 NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED, 64 NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED,
65 false)); 65 false));
66 66
67 CheckViewID(VIEW_ID_TAB_0, true); 67 CheckViewID(VIEW_ID_TAB_0, true);
68 CheckViewID(VIEW_ID_TAB_1, true); 68 CheckViewID(VIEW_ID_TAB_1, true);
69 } 69 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698