src/objects-inl.h - Issue 8968028: Ensure large Smi-only arrays don't transition to FAST_DOUBLE_ARRAY

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 8968028: Ensure large Smi-only arrays don't transition to FAST_DOUBLE_ARRAY (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: review feedback Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 7c7f0940067ad7500c80d1ed416f38c818e7f192..b844da731e1a9919f9c25e76b961ca5bb64acf1e 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -1219,7 +1219,7 @@ void JSObject::ValidateSmiOnlyElements() {

map != heap->free_space_map()) {

for (int i = 0; i < fixed_array->length(); i++) {

Object* current = fixed_array->get(i);

- ASSERT(current->IsSmi() || current == heap->the_hole_value());

+ ASSERT(current->IsSmi() || current->IsTheHole());

}

« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/regress/regress-1849.js » ('j') | no next file with comments »