Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: corelib/src/implementation/promise_implementation.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « corelib/src/implementation/dual_pivot_quicksort.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: corelib/src/implementation/promise_implementation.dart
diff --git a/corelib/src/implementation/promise_implementation.dart b/corelib/src/implementation/promise_implementation.dart
index 64e58d4aff9f0544556169ff5a49844a63241c71..bf2400f2e2b16824a14226f65cdf155569ff409f 100644
--- a/corelib/src/implementation/promise_implementation.dart
+++ b/corelib/src/implementation/promise_implementation.dart
@@ -321,8 +321,8 @@ class ProxyBase extends PromiseImpl<bool> {
// resolved at this point.
SendPortImpl outgoing = _promise.value;
ReceivePort incoming = outgoing._callNow(marshalled);
- incoming.receive((List message, replyTo) {
- result.complete(message[0]);
+ incoming.receive((List receiveMessage, replyTo) {
+ result.complete(receiveMessage[0]);
});
return result;
});
@@ -357,8 +357,8 @@ class ProxyBase extends PromiseImpl<bool> {
completer.complete(msg[0]);
});
entry.addCompleteHandler((value) {
- completer.addCompleteHandler((SendPort port) {
- _marshal([value], (List message) => port.send(message, null));
+ completer.addCompleteHandler((SendPort completePort) {
+ _marshal([value], (List completeMessage) => completePort.send(completeMessage, null));
});
});
} else {
« no previous file with comments | « corelib/src/implementation/dual_pivot_quicksort.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698