compiler/lib/implementation/regexp.dart - Issue 8966029: Report errors and warnings for hiding elements, issue 572.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/lib/implementation/regexp.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fixes for comments Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java ('k') | compiler/lib/implementation/string.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/lib/implementation/regexp.dart

diff --git a/compiler/lib/implementation/regexp.dart b/compiler/lib/implementation/regexp.dart

index cf457ad735abd3a4fbf63b20576fcffcc4e5d6cd..c63046590014118929aff6f3e9739941806a9c65 100644

--- a/compiler/lib/implementation/regexp.dart

+++ b/compiler/lib/implementation/regexp.dart

@@ -38,14 +38,14 @@ class JSSyntaxMatch implements Match {

final String str;

final Pattern pattern;

- String operator[](int group) {

- return this.group(group);

+ String operator[](int group_) {

+ return this.group(group_);

}

- List<String> groups(List<int> groups) {

+ List<String> groups(List<int> groups_) {

List<String> strings = new List<String>();

- groups.forEach((int group) {

- strings.add(this.group(group));

+ groups_.forEach((int group_) {

+ strings.add(this.group(group_));

});

return strings;

}