Report errors and warnings for hiding elements, issue 572.

client/testing/dartest/dartest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('dartest');
 
 #import('dart:dom');
 #import('../unittest/unittest_dartest.dart');
 
 #source('css.dart');
@@ skipping 148 matching lines @@
     }
     
     HTMLSpanElement durationSpan = domWin.document.createElement('span');
     durationSpan.textContent = 'took ${_printDuration(t.runningTime)}';
     tableCell.appendChild(durationSpan);
     
     return tableCell;
   }
   
   /** Update the UI after running test. */
-  void _updateDARTestUI(TestCase test) {
-    _updateResultsTable(test, window);
+  void _updateDARTestUI(TestCase test_) {
+    _updateResultsTable(test_, window);
     if(_runnerWindow != window) {
-      _updateResultsTable(test, _runnerWindow);
+      _updateResultsTable(test_, _runnerWindow);
     }
     
-    if(test.result != null) {
-      _log('  Result: ${test.result.toUpperCase()} ${test.message}');
+    if(test_.result != null) {
+      _log('  Result: ${test_.result.toUpperCase()} ${test_.message}');
     }
-    if(test.runningTime != null) {
-      _log('  took ${_printDuration(test.runningTime)}');
+    if(test_.runningTime != null) {
+      _log('  took ${_printDuration(test_.runningTime)}');
     }
     _updateStatusProgress(_appElements);
     if(_runnerWindow != window) {
       _updateStatusProgress(_inAppElements);
     }
   }
   
   void _updateStatusProgress(AppElements elements) {
     // Update progressbar
     var pPass = 
@@ skipping 43 matching lines @@
     
     _showTestControls();
     
     // Create header to hold window controls
     if(_runnerWindow == window) {
       HTMLDivElement headDiv = _runnerWindow.document.createElement('div');
       headDiv.className = 'dt-header';
       headDiv.innerHTML = 'DARTest: In-App View';
       HTMLImageElement close = _runnerWindow.document.createElement('img');
       close.className = 'dt-header-close';
-      close.addEventListener('click', (Event) {
+      close.addEventListener('click', (event) {
         containerDiv.className = 'dt-hide';
       }, true);
       HTMLImageElement pop = _runnerWindow.document.createElement('img');
       pop.className = 'dt-header-pop';
-      pop.addEventListener('click', (Event) => _dartestMaximize(), true);
+      pop.addEventListener('click', (event) => _dartestMaximize(), true);
       HTMLImageElement minMax = _runnerWindow.document.createElement('img');
       minMax.className = 'dt-header-min';
-      minMax.addEventListener('click', (Event) {
+      minMax.addEventListener('click', (event) {
         if (mainElem.classList.contains('dt-hide')) {
           mainElem.classList.remove('dt-hide');
           mainElem.classList.add('dt-show');
           minMax.className = 'dt-header-min';
         } else {
           if (mainElem.classList.contains('dt-show')) {
             mainElem.classList.remove('dt-show');
           }
           mainElem.classList.add('dt-hide');
           minMax.className = 'dt-header-max';
         }
       }, true);
       headDiv.appendChild(close);
       headDiv.appendChild(pop);
       headDiv.appendChild(minMax);
       
       containerDiv.appendChild(headDiv);
     }
 
     HTMLDivElement tabDiv = _runnerWindow.document.createElement('div');
     tabDiv.className = 'dt-tab';
     HTMLUListElement tabList = _runnerWindow.document.createElement('ul');
     HTMLLIElement testingTab = _runnerWindow.document.createElement('li');
     HTMLLIElement coverageTab = _runnerWindow.document.createElement('li');
     testingTab.className = 'dt-tab-selected';
     testingTab.textContent = 'Testing';
-    testingTab.addEventListener('click', (Event) {
+    testingTab.addEventListener('click', (event) {
       _showTestControls();
       _changeTabs(testingTab, coverageTab);
     }, true);
     tabList.appendChild(testingTab);
     coverageTab.textContent = 'Coverage';
-    coverageTab.addEventListener('click', (Event) {
+    coverageTab.addEventListener('click', (event) {
       _showCoverageControls();
       _changeTabs(coverageTab, testingTab);
     }, true);
     tabList.appendChild(coverageTab); 
     tabDiv.appendChild(tabList);
     containerDiv.appendChild(tabDiv);
     
     if(_runnerWindow != window) {
       HTMLDivElement popIn = _runnerWindow.document.createElement('div');
       popIn.className = 'dt-minimize';
       popIn.innerHTML = 'Pop In ⇲';
-      popIn.addEventListener('click', (Event) => _dartestMinimize(), true);
+      popIn.addEventListener('click', (event) => _dartestMinimize(), true);
       containerDiv.appendChild(popIn);
     }  
     
     containerDiv.appendChild(mainElem);
     _runnerWindow.document.body.appendChild(containerDiv);
   }
   
   void _changeTabs(HTMLLIElement clickedTab, HTMLLIElement oldTab) {
     oldTab.className = '';
     clickedTab.className = 'dt-tab-selected';
   }
   
   void _showTestControls() {
     HTMLDivElement testBody = _appElements.testBody;
     if(testBody == null) {
       testBody = _runnerWindow.document.createElement('div');
       _appElements.testBody = testBody;
     
       // Create a toolbar to hold action buttons
       HTMLDivElement toolDiv = _runnerWindow.document.createElement('div');
       toolDiv.className = 'dt-toolbar';
       HTMLButtonElement runBtn = _runnerWindow.document.createElement('button');
       runBtn.innerHTML = '►';
       runBtn.title = 'Run Tests';
       runBtn.className = 'dt-button dt-run';
-      runBtn.addEventListener('click', (Event) {
+      runBtn.addEventListener('click', (event) {
         _log('Running tests');
         updateUI = _updateDARTestUI;
         runDartests();
       }, true);
       toolDiv.appendChild(runBtn);
       HTMLButtonElement exportBtn = 
         _runnerWindow.document.createElement('button');
       exportBtn.innerHTML = '↷';
       exportBtn.title = 'Export Results';
       exportBtn.className = 'dt-button dt-run';
@@ skipping 185 matching lines @@
 
   static String _lpad(String s, int n) {
     if(s.length < n) {
       for(int i = 0; i < n - s.length; i++) {
         s = '0'+s;
       }
     }
     return s;
   }
 }