Report errors and warnings for hiding elements, issue 572.

client/samples/total/src/SpreadsheetPresenter.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 typedef void EditCellRangeFunction(CellRange range);
 
 /**
  * Spreadsheet widget.
  */
 class SpreadsheetPresenter implements SpreadsheetListener, SelectionListener {
@@ skipping 358 matching lines @@
   // Recalculate the spreadsheet.  The caller is responsible for marking as dirty any cells
   // that require actual recalculation. Code that causes the table to be resized is responsible
   // for updating the DOM table size before this method is called.
   int recalculate() {
     int start = _currentTimeMllis();
     _spreadsheet.beginRecalc();
 
     _setTableWidth(_getVisibleTableWidth());
     _tableSizeChanged();
 
-    int num = _table.redraw(_selectionManager, _rows, _columns,
+    int renderedCells = _table.redraw(_selectionManager, _rows, _columns,
         _rowShift, _columnShift, _cellDisplay);
 
     // Cell sizes may change so update the selection marquee
     _selectionManager.updateSelection();
 
     int calculated = _spreadsheet.endRecalc();
     int end = _currentTimeMllis();
 
     int t = end - start;
     double s = _spreadsheet.calculated * 1000.0 / t;
-    print("Recalculated ${calculated}, rendered ${num} cells in ${t} msec (${s} cells/sec)");
+    print("Recalculated ${calculated}, rendered ${renderedCells} cells in ${t} msec (${s} cells/sec)");
 
     return calculated;
   }
 
   // Recalculate the entire spreadsheet
   void recalculateAll() {
     _spreadsheet.markAllDirty();
     recalculate();
   }
 
@@ skipping 273 matching lines @@
 
       int mouseStartX = e.x;
       int mouseStartY = e.y;
 
       _spreadsheetElement.rect.then((ElementRect elementRect) {
         ClientRect rect = elementRect.bounding;
         int startX = rect.left;
         int startY = rect.top;
         _window.document.body.style.setProperty("cursor", "move");
 
-        _setDragFunction((MouseEvent e) {
-          int x = startX + e.x - mouseStartX;
-          int y = startY + e.y - mouseStartY;
+        _setDragFunction((MouseEvent e_) {
+          int x = startX + e_.x - mouseStartX;
+          int y = startY + e_.y - mouseStartY;
 
           x = Math.max(x, CssStyles.OBJECTBAR_WIDTH);
           y = Math.max(y, CssStyles.SANDBAR_HEIGHT);
           // Move the spreadsheet container
           _spreadsheetElement.style.setProperty("left", HtmlUtils.toPx(x));
           _spreadsheetElement.style.setProperty("top", HtmlUtils.toPx(y));
         });
         });
 
-      _setUndragFunction((MouseEvent e) {
+      _setUndragFunction((MouseEvent e_) {
         _window.document.body.style.setProperty("cursor", "auto");
       });
     });
   }
 
   void _createResizeDragger(Document doc) {
     _resizeDragger = new Element.tag("div");
     _resizeDragger.id = "resizeDragger-${_spreadsheet.name}";
     _resizeDragger.attributes["class"] = "resizeDragger";
     _spreadsheetElement.nodes.add(_resizeDragger);
 
     _resizeDragger.on.mouseDown.add((MouseEvent e) {
       _moveToTop();
 
       // Hide popups
       _hideFormula();
       _popupHandler.deactivatePopup();
 
       int mouseStartX = e.x;
       int mouseStartY = e.y;
       int startX = HtmlUtils.fromPx(_resizeDragger.style.getPropertyValue("left"));
       int startY = HtmlUtils.fromPx(_resizeDragger.style.getPropertyValue("top"));
       _window.document.body.style.setProperty("cursor", "move");
 
-      _setDragFunction((MouseEvent e) {
-        int x = startX + e.x - mouseStartX;
-        int y = startY + e.y - mouseStartY;
+      _setDragFunction((MouseEvent e_) {
+        int x = startX + e_.x - mouseStartX;
+        int y = startY + e_.y - mouseStartY;
 
         // Move the drag handle
         _resizeDragger.style.setProperty("left", HtmlUtils.toPx(x));
         _resizeDragger.style.setProperty("top", HtmlUtils.toPx(y));
 
         int column = _getMaxRowOrColumn(x, COL);
         int row = _getMaxRowOrColumn(y, ROW) + 1;
         if (column == -1 || row == -1) {
           return;
         }
@@ skipping 13 matching lines @@
           }
           _removeTableRowHtml(_rows);
           _rows--;
         }
         while (row > _rows + _rowShift) {
           _spreadsheet.insertRow(_rows, _spreadsheet.getDefaultRowHeight(_rows));
         }
         _spreadsheet.refresh();
       });
 
-      _setUndragFunction((MouseEvent e) {
+      _setUndragFunction((MouseEvent e_) {
         _window.document.body.style.setProperty("cursor", "auto");
       });
     });
 
     _refreshResizeDragger();
   }
 
   // Initialize the HTML elements used to indicate dragging
   void _createSpreadsheetLayout(Document doc) {
     DivElement columnDraggerElement = new Element.tag("div");
@@ skipping 775 matching lines @@
           ClientRect boundingRect = rect.bounding;
           int scrollOffsetX = -boundingRect.left;
           int scrollOffsetY = -boundingRect.top;
           _contextMenu.show(e.x + scrollOffsetX, e.y + scrollOffsetY);
         });
         return;
       }
 
       _setDragFunction(mouseMove);
 
-      _setUndragFunction((MouseEvent e) {
+      _setUndragFunction((MouseEvent e_) {
         dragRowColumn(true);
         _table.setDefaultCursor();
         draggingSelection = false;
         draggingRowColumn[COL] = -1;
         setDrag(COL, false);
         draggingRowColumn[ROW] = -1;
         setDrag(ROW, false);
         // Finalize the selection
         _selectionManager.selectionChanged();
         // Check to see if the selection we just finalized is a request
@@ skipping 30 matching lines @@
         return;
       }
 
       // Click on cell during formula editing
       if (_formulaEditing) {
         _formulaCellSelecting = true;
         _formulaCellSelectingRememberSelectionRange();
         // disable text selection, because browser inverts selection once we drag over input
         _formulaInput.style.setProperty("-webkit-user-select", "none");
         // listen for drag operation
-        _setDragFunction((MouseEvent e) {
-          Element target = e.target;
-          CellLocation location = _getCellLocation(target);
-          if (location == null) {
+        _setDragFunction((MouseEvent e_) {
+          Element target_ = e_.target;
+          CellLocation location_ = _getCellLocation(target_);
+          if (location_ == null) {
             return;
           }
-          _formulaCellSelectingInsertReference(null, location.rowCol);
+          _formulaCellSelectingInsertReference(null, location_.rowCol);
         });
-        _setUndragFunction((MouseEvent e) {
+        _setUndragFunction((MouseEvent e_) {
           _formulaInput.style.removeProperty("-webkit-user-select");
           _formulaCellSelectingSelectText();
         });
         // set "click" location
         _formulaCellSelectingInsertReference(location.rowCol, null);
         return;
       }
 
       // Begin selection
       draggingSelection = true;
@@ skipping 98 matching lines @@
       _spreadsheet.execute(command);
     } else {
       if (rowOrCol == COL) {
         _spreadsheet.setColumnWidth(index, size);
       } else {
         _spreadsheet.setRowHeight(index, size);
       }
     }
   }
 }