Report errors and warnings for hiding elements, issue 572.

client/samples/spirodraw/Spirodraw.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('spirodraw');
 
 #import('dart:dom');
 #source("ColorPicker.dart");
 // TODO(732): Reenable when this works in the VM.
 // #resource("spirodraw.css");
@@ skipping 39 matching lines @@
     penRadiusSlider = doc.getElementById("pen_radius");
     penWidthSlider = doc.getElementById("pen_width");
     speedSlider = doc.getElementById("speed");
     numTurns = doc.getElementById("num_turns");
     mainDiv = doc.getElementById("main");
     frontCanvas = doc.getElementById("canvas");
     front = frontCanvas.getContext("2d");
     backCanvas = doc.createElement("canvas");
     back = backCanvas.getContext("2d");
     paletteElement = doc.getElementById("palette");
-    window.addEventListener('resize', (Event) => onResize(), true);
+    window.addEventListener('resize', (event) => onResize(), true);
     initControlPanel();
   }
 
   void go() {
     onResize();
   }
   
   void onResize() {
     height = window.innerHeight;
     width = window.innerWidth - 270;
     yc = height~/2;
     xc = width~/2;
     frontCanvas.height = height;
     frontCanvas.width = width;
     backCanvas.height = height;
     backCanvas.width = width;
     clear();
   }
   
   void initControlPanel() {
-    inOrOut.addEventListener('change', (Event) => refresh(), true);
-    fixedRadiusSlider.addEventListener('change', (Event) => refresh(), true);
-    wheelRadiusSlider.addEventListener('change', (Event) => refresh(), true);
-    speedSlider.addEventListener('change', (Event) => onSpeedChange(), true);
-    penRadiusSlider.addEventListener('change', (Event) => refresh(), true);
-    penWidthSlider.addEventListener('change', (Event) => onPenWidthChange(), true);
+    inOrOut.addEventListener('change', (event) => refresh(), true);
+    fixedRadiusSlider.addEventListener('change', (event) => refresh(), true);
+    wheelRadiusSlider.addEventListener('change', (event) => refresh(), true);
+    speedSlider.addEventListener('change', (event) => onSpeedChange(), true);
+    penRadiusSlider.addEventListener('change', (event) => refresh(), true);
+    penWidthSlider.addEventListener('change', (event) => onPenWidthChange(), true);
     colorPicker = new ColorPicker(paletteElement);
     colorPicker.addListener((String color) => onColorChange(color));
-    doc.getElementById("start").addEventListener('click', (EventListener) => start(), true);
-    doc.getElementById("stop").addEventListener('click', (EventListener) => stop(), true);
-    doc.getElementById("clear").addEventListener('click', (EventListener) => clear(), true);
-    doc.getElementById("lucky").addEventListener('click', (EventListener) => lucky(), true);
+    doc.getElementById("start").addEventListener('click', (event) => start(), true);
+    doc.getElementById("stop").addEventListener('click', (event) => stop(), true);
+    doc.getElementById("clear").addEventListener('click', (event) => clear(), true);
+    doc.getElementById("lucky").addEventListener('click', (event) => lucky(), true);
   }
   
   void onColorChange(String color) {
     penColor = color;
     drawFrame(rad);
   }
 
   void onSpeedChange() {
     speed = speedSlider.valueAsNumber;
     stepSize = calcStepSize();
@@ skipping 24 matching lines @@
     onSpeedChange();
     numTurns.innerText = "0" + "/" + maxTurns;
     penWidth = penWidthSlider.valueAsNumber;
     drawFrame(0.0);
   }
 
   int calcNumPoints() {
     if ((dUnits==0) || (rUnits==0))
       // Empirically, treat it like an oval
       return 2;
-    int gcf = gcf(RUnits, rUnits);
-    int n = RUnits ~/ gcf;
-    int d = rUnits ~/ gcf;
+    int gcf_ = gcf(RUnits, rUnits);
+    int n = RUnits ~/ gcf_;
+    int d_ = rUnits ~/ gcf_;
     if (n % 2 == 1)
       // odd
       return n;
-    else if (d %2 == 1)
+    else if (d_ %2 == 1)
       return n;
     else
       return n~/2;
   }
 
   // TODO return optimum step size in radians
   double calcStepSize() => speed / 100 * maxTurns / numPoints;
 
   void drawFrame(double theta) {
     if (animationEnabled) {
@@ skipping 147 matching lines @@
 
 int gcf(int n, int d) {
   if (n==d)
     return n;
   int max = Math.max(n, d);
   for (int i = max ~/ 2; i > 1; i--)
     if ((n % i == 0) && (d % i == 0))
       return i;
   return 1;
 }