Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/webdata/web_intents_table.cc

Issue 8966003: Update webdata files to take advantage of DLOG(FATAL) in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add header comments for a couple tricky error cases. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/web_database_migration_unittest.cc ('k') | sql/statement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/web_intents_table.cc
diff --git a/chrome/browser/webdata/web_intents_table.cc b/chrome/browser/webdata/web_intents_table.cc
index 61bf89ad9afe853fd4c1b4caee8fb01f53241328..b717ba4a611425347c7b8aca828631e12e145ba9 100644
--- a/chrome/browser/webdata/web_intents_table.cc
+++ b/chrome/browser/webdata/web_intents_table.cc
@@ -34,7 +34,7 @@ bool ExtractIntents(sql::Statement* s,
service.disposition = WebIntentServiceData::DISPOSITION_INLINE;
services->push_back(service);
}
- return true;
+ return s->Succeeded();
}
} // namespace
@@ -79,8 +79,8 @@ bool WebIntentsTable::GetWebIntentServices(
sql::Statement s(db_->GetUniqueStatement(
"SELECT service_url, action, type, title, disposition FROM web_intents "
"WHERE action=?"));
-
s.BindString16(0, action);
+
return ExtractIntents(&s, services);
}
@@ -94,8 +94,8 @@ bool WebIntentsTable::GetWebIntentServicesForURL(
sql::Statement s(db_->GetUniqueStatement(
"SELECT service_url, action, type, title, disposition FROM web_intents "
"WHERE service_url=?"));
-
s.BindString16(0, service_url);
+
return ExtractIntents(&s, services);
}
@@ -123,6 +123,7 @@ bool WebIntentsTable::SetWebIntentService(const WebIntentServiceData& service) {
s.BindString16(2, service.action);
s.BindString16(3, service.title);
s.BindString16(4, disposition);
+
return s.Run();
}
@@ -134,9 +135,9 @@ bool WebIntentsTable::RemoveWebIntentService(
sql::Statement s(db_->GetUniqueStatement(
"DELETE FROM web_intents "
"WHERE service_url = ? AND action = ? AND type = ?"));
-
s.BindString(0, service.service_url.spec());
s.BindString16(1, service.action);
s.BindString16(2, service.type);
+
return s.Run();
}
« no previous file with comments | « chrome/browser/webdata/web_database_migration_unittest.cc ('k') | sql/statement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698