Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 8965073: delete missing js file (Closed)

Created:
8 years, 12 months ago by guanqun
Modified:
8 years, 11 months ago
Reviewers:
dominich, nduca
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

delete missing js file In revision 110671, chrome/browser/resources/tracing/tracing_controller_tests.js is deleted, so here this line is deleted correspondingly. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116733

Patch Set 1 #

Patch Set 2 : delete missing js file #

Patch Set 3 : delete missing js file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/gpu_internals/timeline_test.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
nduca
LGTM
8 years, 11 months ago (2012-01-03 21:33:01 UTC) #1
dominich
lgtm
8 years, 11 months ago (2012-01-03 21:43:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Guanqun.Lu@gmail.com/8965073/1
8 years, 11 months ago (2012-01-03 21:44:30 UTC) #3
commit-bot: I haz the power
Presubmit check for 8965073-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 11 months ago (2012-01-03 21:44:33 UTC) #4
guanqun
I've added a new commit to add my name to AUTHORS. FYI, I've signed the ...
8 years, 11 months ago (2012-01-04 00:54:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Guanqun.Lu@gmail.com/8965073/5001
8 years, 11 months ago (2012-01-05 20:59:53 UTC) #6
commit-bot: I haz the power
Can't apply patch for file AUTHORS. While running patch -p1 --forward --force; patching file AUTHORS ...
8 years, 11 months ago (2012-01-05 20:59:55 UTC) #7
guanqun
I've rebased this patch on the latest commit, and this should solve the AUTHORS conflict ...
8 years, 11 months ago (2012-01-06 00:53:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Guanqun.Lu@gmail.com/8965073/11001
8 years, 11 months ago (2012-01-06 19:02:17 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-06 20:52:46 UTC) #10
Change committed as 116733

Powered by Google App Engine
This is Rietveld 408576698