Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: chrome/browser/bookmarks/bookmark_utils.h

Issue 8965054: Coverity: Initialize member variables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_ 5 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_ 6 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 234
235 // Number of bookmarks we'll open before prompting the user to see if they 235 // Number of bookmarks we'll open before prompting the user to see if they
236 // really want to open all. 236 // really want to open all.
237 // 237 //
238 // NOTE: treat this as a const. It is not const as various tests change the 238 // NOTE: treat this as a const. It is not const as various tests change the
239 // value. 239 // value.
240 extern int num_urls_before_prompting; 240 extern int num_urls_before_prompting;
241 241
242 // This enum is used for the Bookmarks.LaunchLocation histogram. 242 // This enum is used for the Bookmarks.LaunchLocation histogram.
243 enum BookmarkLaunchLocation { 243 enum BookmarkLaunchLocation {
244 LAUNCH_NONE,
244 LAUNCH_ATTACHED_BAR = 0, 245 LAUNCH_ATTACHED_BAR = 0,
245 LAUNCH_DETACHED_BAR, 246 LAUNCH_DETACHED_BAR,
246 // These two are kind of sub-categories of the bookmark bar. Generally 247 // These two are kind of sub-categories of the bookmark bar. Generally
247 // a launch from a context menu or subfolder could be classified in one of 248 // a launch from a context menu or subfolder could be classified in one of
248 // the other two bar buckets, but doing so is difficult because the menus 249 // the other two bar buckets, but doing so is difficult because the menus
249 // don't know of their greater place in Chrome. 250 // don't know of their greater place in Chrome.
250 LAUNCH_BAR_SUBFOLDER, 251 LAUNCH_BAR_SUBFOLDER,
251 LAUNCH_CONTEXT_MENU, 252 LAUNCH_CONTEXT_MENU,
252 253
253 // Bookmarks menu within wrench menu. 254 // Bookmarks menu within wrench menu.
254 LAUNCH_WRENCH_MENU, 255 LAUNCH_WRENCH_MENU,
255 // Bookmark manager. 256 // Bookmark manager.
256 LAUNCH_MANAGER, 257 LAUNCH_MANAGER,
257 // Autocomplete suggestion. 258 // Autocomplete suggestion.
258 LAUNCH_OMNIBOX, 259 LAUNCH_OMNIBOX,
259 260
260 LAUNCH_LIMIT // Keep this last. 261 LAUNCH_LIMIT // Keep this last.
261 }; 262 };
262 263
263 // Records the launch of a bookmark for UMA purposes. 264 // Records the launch of a bookmark for UMA purposes.
264 void RecordBookmarkLaunch(BookmarkLaunchLocation location); 265 void RecordBookmarkLaunch(BookmarkLaunchLocation location);
265 266
266 } // namespace bookmark_utils 267 } // namespace bookmark_utils
267 268
268 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_ 269 #endif // CHROME_BROWSER_BOOKMARKS_BOOKMARK_UTILS_H_
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete_history_manager.cc ('k') | chrome/browser/extensions/extension_tts_api_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698