Issue 8965054: Coverity: Initialize member variables.

Issue 8965054: Coverity: Initialize member variables. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
Wez, binji

CC:
chromium-reviews, vrk (LEFT CHROMIUM), jam, amit, mihaip+watch_chromium.org, dhollowa+watch_chromium.org, jonathan.backer, acolwell+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, annacc+watch_chromium.org, ihf+watch_chromium.org, jstritar+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, sanjeevr, dpranke-watch+content_chromium.org, simonmorris+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Ian Vollick, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Initialize member variables. CID=100356,100360,100368,100373,100374,100562,101529,101530,101536,101541, 101542,101595,101630,101685,101687,101689,101776,101812,101813,101854, 101861,101862,101871,101883,101886,101887,102034 BUG=none TEST=none R=binji Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115225

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review fixes. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -19 lines)			Patch
M	base/file_util_win.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete_history_manager.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_tts_api_win.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/login/login_prompt_win.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/content_settings.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/profiling.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_connector.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/browser_process_sub_thread.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/plugin_loader_posix.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/plugin_loader_posix.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/media/media_stream_dispatcher_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/zygote_main_linux.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	content/gpu/gpu_child_thread.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/video_capture_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/webrtc_audio_device_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/renderer_accessibility.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/websharedworker_proxy.h	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	media/video/capture/win/pin_base_win.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	media/video/capture/win/video_capture_device_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppp_mouse_lock_proxy.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/base/decoder_row_based.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	remoting/client/rectangle_update_decoder.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/layer_animation_element.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/render_text.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/render_text_win.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm http://codereview.chromium.org/8965054/diff/1/content/renderer/websharedworker_proxy.cc File content/renderer/websharedworker_proxy.cc (right): http://codereview.chromium.org/8965054/diff/1/content/renderer/websharedworker_proxy.cc#newcode22 content/renderer/websharedworker_proxy.cc:22: parent_appcache_host_id_(-1), Why is -1 a safe value for ...

9 years ago (2011-12-20 20:00:04 UTC) #2

Wez

Thanks for these! http://codereview.chromium.org/8965054/diff/1/remoting/base/decoder_row_based.cc File remoting/base/decoder_row_based.cc (right): http://codereview.chromium.org/8965054/diff/1/remoting/base/decoder_row_based.cc#newcode37 remoting/base/decoder_row_based.cc:37: memset(&clip_, 0, sizeof(clip_)); This should be: ...

9 years ago (2011-12-20 20:08:01 UTC) #3

James Hawkins

9 years ago (2011-12-20 20:48:49 UTC) #4

http://codereview.chromium.org/8965054/diff/1/content/renderer/websharedworke...
File content/renderer/websharedworker_proxy.cc (right):

http://codereview.chromium.org/8965054/diff/1/content/renderer/websharedworke...
content/renderer/websharedworker_proxy.cc:22: parent_appcache_host_id_(-1),
On 2011/12/20 20:00:06, binji wrote:
> Why is -1 a safe value for this?

moot point, I deleted the variable since it's unused.

http://codereview.chromium.org/8965054/diff/1/remoting/base/decoder_row_based.cc
File remoting/base/decoder_row_based.cc (right):

http://codereview.chromium.org/8965054/diff/1/remoting/base/decoder_row_based...
remoting/base/decoder_row_based.cc:37: memset(&clip_, 0, sizeof(clip_));
On 2011/12/20 20:08:02, Wez wrote:
> This should be:
> 
> clip_(SkIRect::MakeEmpty())

Done.

http://codereview.chromium.org/8965054/diff/1/remoting/client/rectangle_updat...
File remoting/client/rectangle_update_decoder.cc (right):

http://codereview.chromium.org/8965054/diff/1/remoting/client/rectangle_updat...
remoting/client/rectangle_update_decoder.cc:29: memset(&initial_screen_size_, 0,
sizeof(initial_screen_size_));
On 2011/12/20 20:08:02, Wez wrote:
> Similarly, SkIRect::MakeEmpty() for |clip_rect_| and SkISize::Make(0, 0) for
> |initial_screen_size|.

Done.

Expand Messages | Collapse Messages