Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 8965049: Fixed CID 102675, uninitialized member vars (Closed)

Created:
9 years ago by groby-ooo-7-16
Modified:
9 years ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Fixed CID 102675, uninitialized member vars CID=102675, 102638 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115579

Patch Set 1 #

Patch Set 2 : More audio device uninit fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M base/sync_socket.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/sync_socket_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sync_socket_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/audio_device.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/audio_input_device.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
groby-ooo-7-16
9 years ago (2011-12-20 19:04:06 UTC) #1
James Hawkins
LGTM
9 years ago (2011-12-20 20:09:18 UTC) #2
groby-ooo-7-16
A few more fixes
9 years ago (2011-12-20 23:47:49 UTC) #3
James Hawkins
SLGTM
9 years ago (2011-12-20 23:52:44 UTC) #4
groby-ooo-7-16
maruel, fischman: OWNERS stamp please?
9 years ago (2011-12-22 00:39:35 UTC) #5
Ami GONE FROM CHROMIUM
media LGTM
9 years ago (2011-12-22 05:42:28 UTC) #6
M-A Ruel
Deflecting to Brett
9 years ago (2011-12-22 14:14:20 UTC) #7
brettw
lgtm
9 years ago (2011-12-22 15:50:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8965049/4001
9 years ago (2011-12-22 17:53:55 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-22 19:33:33 UTC) #10
Change committed as 115579

Powered by Google App Engine
This is Rietveld 408576698