Coverity: Fixing pass by value bugs

chrome/browser/extensions/apps_promo.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/apps_promo.h"
 
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 294 matching lines @@
 
 AppsPromo::UserGroup AppsPromo::GetCurrentUserGroup() const {
   const PrefService::Preference* last_promo_id
       = prefs_->FindPreference(prefs::kNTPWebStorePromoLastId);
   CHECK(last_promo_id);
   return last_promo_id->IsDefaultValue() ? USERS_NEW : USERS_EXISTING;
 }
 
 AppsPromoLogoFetcher::AppsPromoLogoFetcher(
     Profile* profile,
-    AppsPromo::PromoData promo_data)
+    const AppsPromo::PromoData& promo_data)
     : profile_(profile),
       promo_data_(promo_data) {
   if (SupportsLogoURL()) {
     if (HaveCachedLogo()) {
       promo_data_.logo = AppsPromo::GetPromo().logo;
       SavePromo();
     } else {
       FetchLogo();
     }
   } else {
@@ skipping 50 matching lines @@
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_WEB_STORE_PROMO_LOADED,
       content::Source<Profile>(profile_),
       content::NotificationService::NoDetails());
 }
 
 bool AppsPromoLogoFetcher::SupportsLogoURL() {
   URLPattern allowed_urls(URLPattern::SCHEME_HTTPS, kValidLogoPattern);
   return allowed_urls.MatchesURL(promo_data_.logo);
 }