Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: webkit/fileapi/sandbox_mount_point_provider.h

Issue 8965041: Cleanup: Reorder methods in SandboxMountPointProvider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/fileapi/sandbox_mount_point_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/sandbox_mount_point_provider.h
diff --git a/webkit/fileapi/sandbox_mount_point_provider.h b/webkit/fileapi/sandbox_mount_point_provider.h
index 11a47737781402f63ff34d8d2af84144d8d0204f..b18e0f9b221f109be34111f3016e830fd042a212 100644
--- a/webkit/fileapi/sandbox_mount_point_provider.h
+++ b/webkit/fileapi/sandbox_mount_point_provider.h
@@ -49,51 +49,42 @@ class SandboxMountPointProvider
virtual bool HasFileSystemType(FileSystemType type) const = 0;
};
+ // The legacy [pre-obfuscation] FileSystem directory name, kept around for
+ // migration and migration testing.
+ static const FilePath::CharType kOldFileSystemDirectory[];
+ // The FileSystem directory name.
+ static const FilePath::CharType kNewFileSystemDirectory[];
+ // Where we move the old filesystem directory if migration fails.
+ static const FilePath::CharType kRenamedOldFileSystemDirectory[];
+
SandboxMountPointProvider(
FileSystemPathManager* path_manager,
scoped_refptr<base::MessageLoopProxy> file_message_loop,
const FilePath& profile_path);
virtual ~SandboxMountPointProvider();
- // Checks if access to |virtual_path| is allowed from |origin_url|.
+ // FileSystemMountPointProvider overrides.
virtual bool IsAccessAllowed(const GURL& origin_url,
FileSystemType type,
const FilePath& virtual_path) OVERRIDE;
-
- // Retrieves the root path for the given |origin_url| and |type|, and
- // calls the given |callback| with the root path and name.
- // If |create| is true this also creates the directory if it doesn't exist.
virtual void ValidateFileSystemRootAndGetURL(
const GURL& origin_url,
FileSystemType type,
bool create,
const FileSystemPathManager::GetRootPathCallback& callback) OVERRIDE;
-
- // Like GetFileSystemRootPath, but synchronous, and can be called only while
- // running on the file thread.
virtual FilePath ValidateFileSystemRootAndGetPathOnFileThread(
const GURL& origin_url,
FileSystemType type,
const FilePath& unused,
bool create) OVERRIDE;
-
- // The legacy [pre-obfuscation] FileSystem directory name, kept around for
- // migration and migration testing.
- static const FilePath::CharType kOldFileSystemDirectory[];
- // The FileSystem directory name.
- static const FilePath::CharType kNewFileSystemDirectory[];
- // Where we move the old filesystem directory if migration fails.
- static const FilePath::CharType kRenamedOldFileSystemDirectory[];
+ virtual bool IsRestrictedFileName(const FilePath& filename) const OVERRIDE;
+ virtual std::vector<FilePath> GetRootDirectories() const OVERRIDE;
+ virtual FileSystemFileUtil* GetFileUtil() OVERRIDE;
FilePath old_base_path() const;
FilePath new_base_path() const;
FilePath renamed_old_base_path() const;
- // Checks if a given |name| contains any restricted names/chars in it.
- virtual bool IsRestrictedFileName(const FilePath& filename) const OVERRIDE;
-
- virtual std::vector<FilePath> GetRootDirectories() const OVERRIDE;
-
// Returns an origin enumerator of this provider.
// This method can only be called on the file thread.
OriginEnumerator* CreateOriginEnumerator() const;
@@ -109,8 +100,6 @@ class SandboxMountPointProvider
FileSystemType type,
bool create) const;
- virtual FileSystemFileUtil* GetFileUtil() OVERRIDE;
-
// Deletes the data on the origin and reports the amount of deleted data
// to the quota manager via |proxy|.
bool DeleteOriginDataOnFileThread(
« no previous file with comments | « no previous file | webkit/fileapi/sandbox_mount_point_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698