Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 8965038: Clean up handling of global cell stores in the optimizing compiler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1761 matching lines...) Expand 10 before | Expand all | Expand 10 after
1772 1772
1773 1773
1774 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) { 1774 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
1775 LOperand* global_object = UseFixed(instr->global_object(), r0); 1775 LOperand* global_object = UseFixed(instr->global_object(), r0);
1776 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(global_object); 1776 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(global_object);
1777 return MarkAsCall(DefineFixed(result, r0), instr); 1777 return MarkAsCall(DefineFixed(result, r0), instr);
1778 } 1778 }
1779 1779
1780 1780
1781 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 1781 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
1782 LOperand* temp = TempRegister(); 1782 LOperand* value = UseRegister(instr->value());
1783 LOperand* value = UseTempRegister(instr->value()); 1783 // Use a temp to check the value in the cell in the case where we perform
1784 LInstruction* result = new LStoreGlobalCell(value, temp); 1784 // a hole check.
1785 if (instr->RequiresHoleCheck()) result = AssignEnvironment(result); 1785 return instr->RequiresHoleCheck()
1786 return result; 1786 ? AssignEnvironment(new LStoreGlobalCell(value, TempRegister()))
1787 : new LStoreGlobalCell(value, NULL);
1787 } 1788 }
1788 1789
1789 1790
1790 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) { 1791 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
1791 LOperand* global_object = UseFixed(instr->global_object(), r1); 1792 LOperand* global_object = UseFixed(instr->global_object(), r1);
1792 LOperand* value = UseFixed(instr->value(), r0); 1793 LOperand* value = UseFixed(instr->value(), r0);
1793 LStoreGlobalGeneric* result = 1794 LStoreGlobalGeneric* result =
1794 new LStoreGlobalGeneric(global_object, value); 1795 new LStoreGlobalGeneric(global_object, value);
1795 return MarkAsCall(result, instr); 1796 return MarkAsCall(result, instr);
1796 } 1797 }
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
2238 2239
2239 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2240 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2240 LOperand* key = UseRegisterAtStart(instr->key()); 2241 LOperand* key = UseRegisterAtStart(instr->key());
2241 LOperand* object = UseRegisterAtStart(instr->object()); 2242 LOperand* object = UseRegisterAtStart(instr->object());
2242 LIn* result = new LIn(key, object); 2243 LIn* result = new LIn(key, object);
2243 return MarkAsCall(DefineFixed(result, r0), instr); 2244 return MarkAsCall(DefineFixed(result, r0), instr);
2244 } 2245 }
2245 2246
2246 2247
2247 } } // namespace v8::internal 2248 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698