Refactoring of job dispatch in HostResolverImpl in preparation for DnsClient.

net/base/net_log_event_type_list.h

Index: net/base/net_log_event_type_list.h
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index aa5f140a07c2028000c61c2b1f56c01374a91964..d509efcdde365c70f827b2413d1d6b102bf7abde 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -58,32 +58,56 @@ EVENT_TYPE(HOST_RESOLVER_IMPL)
 //     "net_error": <The net error code integer for the failure>,
 //     "os_error": <The exact error code integer that getaddrinfo() returned>,
 //   }
-
 EVENT_TYPE(HOST_RESOLVER_IMPL_REQUEST)
 
 // This event is logged when a request is handled by a cache entry.
 EVENT_TYPE(HOST_RESOLVER_IMPL_CACHE_HIT)
 
-// This event means a request was queued/dequeued for subsequent job creation,
-// because there are already too many active HostResolverImpl::Jobs.
+// This event is created when a new HostResolverImpl::Job is about to be created
+// for a request.
+EVENT_TYPE(HOST_RESOLVER_IMPL_CREATE_JOB)
+
+// The creation/completion of a HostResolverImpl::Job which is created for
+// Requests that cannot be resolved synchronously.
 //
 // The BEGIN phase contains the following parameters:
 //
 //   {
-//     "priority": <Priority of the queued request>,
+//     "host": <Hostname associated with the request>,
+//     "source_dependency": <Source id, if any, of what created the request>,
+//     "priority": <Priority of the job>,
+//   }
+//
+// On success, the END phase has these parameters:
+//   {
+//     "address_list": <The host name being resolved>,
+//   }
+// If an error occurred, the END phase will contain these parameters:
+//   {
+//     "net_error": <The net error code integer for the failure>,
+//     "os_error": <The exact error code integer that getaddrinfo() returned>,
+//   }
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB)
+
+// This event is created whenever the priority of the job changes.
+//
+// The event has the parameters:
+//
+//   {
+//     "priority": <New priority of the job>,
 //   }
-EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_POOL_QUEUE)
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_PRIORITY_UPDATED)
 
-// This event is created when a new HostResolverImpl::Request is evicted from
-// JobPool without a Job being created, because the limit on number of queued
-// Requests was reached.
-EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_POOL_QUEUE_EVICTED)
+// This event is created when a a HostResolverImpl::Job is evicted from

[mmenke, 2011/12/21 16:22:58]

nit:  Remove second "a"

[szym, 2011/12/28 01:24:10]

Done.

+// PriorityDispatch before it can start, because the limit on number of queued
+// Jobs was reached.
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_EVICTED)
 
-// This event is created when a new HostResolverImpl::Job is about to be created
-// for a request.
-EVENT_TYPE(HOST_RESOLVER_IMPL_CREATE_JOB)
+// This event is created when a a HostResolverImpl::Job is started by

[mmenke, 2011/12/21 16:22:58]

nit:  Remove second "a"

[szym, 2011/12/28 01:24:10]

Done.

+// PriorityDispatch.
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_STARTED)
 
-// This event is created when HostResolverImpl::Job is about to start a new
+// This event is created when HostResolverImpl::ProcJob is about to start a new
 // attempt to resolve the host.
 //
 // The ATTEMPT_STARTED event has the parameters:
@@ -93,8 +117,8 @@ EVENT_TYPE(HOST_RESOLVER_IMPL_CREATE_JOB)
 //   }
 EVENT_TYPE(HOST_RESOLVER_IMPL_ATTEMPT_STARTED)
 
-// This event is created when HostResolverImpl::Job has finished resolving the
-// host.
+// This event is created when HostResolverImpl::ProcJob has finished resolving
+// the host.
 //
 // The ATTEMPT_FINISHED event has the parameters:
 //
@@ -109,24 +133,24 @@ EVENT_TYPE(HOST_RESOLVER_IMPL_ATTEMPT_STARTED)
 EVENT_TYPE(HOST_RESOLVER_IMPL_ATTEMPT_FINISHED)
 
 // This is logged for a request when it's attached to a
-// HostResolverImpl::Job.  When this occurs without a preceding
+// HostResolverImpl::Job. When this occurs without a preceding
 // HOST_RESOLVER_IMPL_CREATE_JOB entry, it means the request was attached to an
 // existing HostResolverImpl::Job.
 //
-// If the BoundNetLog used to create the event has a valid source id, the BEGIN
-// phase contains the following parameters:
+// If the BoundNetLog used to create the event has a valid source id, the event
+// contains the following parameters:
 //
 //   {
 //     "source_dependency": <Source identifier for the attached Job>,
 //   }
 EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_ATTACH)
 
-// The creation/completion of a host resolve (DNS) job.
+// The creation/completion of a HostResolverImpl::ProcJob to call getaddrinfo.
 // The BEGIN phase contains the following parameters:
 //
 //   {
 //     "host": <Hostname associated with the request>,
-//     "source_dependency": <Source id, if any, of what created the request>,
+//     "source_dependency": <Source id of parent HostResolverImpl::Job>,
 //   }
 //
 // On success, the END phase has these parameters:
@@ -138,7 +162,7 @@ EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_ATTACH)
 //     "net_error": <The net error code integer for the failure>,
 //     "os_error": <The exact error code integer that getaddrinfo() returned>,
 //   }
-EVENT_TYPE(HOST_RESOLVER_IMPL_JOB)
+EVENT_TYPE(HOST_RESOLVER_IMPL_PROC_JOB)
 
 // ------------------------------------------------------------------------
 // InitProxyResolver