Refactoring of job dispatch in HostResolverImpl in preparation for DnsClient.

net/base/priority_dispatch.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/base/priority_dispatch.h"
+
+#include "base/logging.h"
+
+namespace net {
+
+// We rely on the priority enum values being sequential having starting at 0,
+// and increasing for lower priorities.
+COMPILE_ASSERT(HIGHEST == 0u &&
+               LOWEST > HIGHEST &&
+               IDLE > LOWEST &&
+               NUM_PRIORITIES > IDLE,
+               priority_indexes_incompatible);
+
+// static
+PriorityDispatch::Limits PriorityDispatch::Limits::MakeAny(
+    size_t max_idle) {
+  Limits limits = {{0, 0, 0, 0, max_idle}};

[mmenke, 2011/12/21 16:22:58]

You're relying on NUM_PRIORITIES being 5 here.  Think it's best to remove that
dependency, since it doesn't appear anywhere else in your CL, that I can see.

[szym, 2011/12/28 01:24:10]

Done.

+  return limits;
+}
+
+size_t PriorityDispatch::Limits::Total() const {
+  size_t total = 0;
+  for (size_t i = 0; i < NUM_PRIORITIES; ++i) {
+    total+= reserved_slots[i];

[mmenke, 2011/12/21 16:22:58]

nit:  Space before the +=.  Applies elsewhere in this file, too.

[szym, 2011/12/28 01:24:10]

Done.

+  }
+  return total;
+}
+
+PriorityDispatch::PriorityDispatch(const Limits& limits, size_t max_queued)
+    : num_running_jobs_(0), max_queued_jobs_(max_queued) {
+  size_t total = 0;
+  for (size_t i = 0; i < NUM_PRIORITIES; ++i) {
+    total+= limits.reserved_slots[NUM_PRIORITIES - i - 1];
+    max_running_jobs_[NUM_PRIORITIES - i - 1] = total;
+  }
+}
+
+PriorityDispatch::~PriorityDispatch() {}
+
+void PriorityDispatch::SetMaxQueued(size_t max_queued) {
+  DCHECK_EQ(0u, num_queued_jobs());
+  max_queued_jobs_ = max_queued;
+}
+
+PriorityDispatch::Handle PriorityDispatch::Add(Job* job,
+                                               RequestPriority priority) {
+  DCHECK(job);
+  if (num_running_jobs_ < max_running_jobs_[priority]) {
+    ++num_running_jobs_;
+    job->Start();
+    return Handle();
+  }
+  Handle handle = queue_.Insert(job, priority);
+  if (queue_.size() > max_queued_jobs_) {
+    // Evict oldest lowest-priority job.
+    Handle evicted = queue_.OldestLowest();
+    DCHECK(!evicted.is_null());
+    if (evicted.equals(handle))
+      handle = Handle();
+    Job* evicted_job = evicted.value();
+    queue_.Erase(evicted);
+    DCHECK(evicted_job);
+    evicted_job->OnEvicted();
+  }
+  return handle;
+}
+
+void PriorityDispatch::Cancel(const Handle& handle) {
+  queue_.Erase(handle);
+}
+
+PriorityDispatch::Handle PriorityDispatch::Update(const Handle& handle,
+                                                  RequestPriority priority) {
+  DCHECK(!handle.is_null());
+  DCHECK_GE(num_running_jobs_, max_running_jobs_[handle.priority()]) <<
+      "Job should not be in queue when limits permit it to start.";
+  if (num_running_jobs_ < max_running_jobs_[priority]) {

[mmenke, 2011/12/21 16:22:58]

You're pretty much duplicating half of OnJobFinished here.  Not a lot of code,
but think it's best to go ahead and make it a function. 

[szym, 2011/12/28 01:24:10]

Done.

+    Job* job = handle.value();
+    queue_.Erase(handle);
+    ++num_running_jobs_;
+    DCHECK(job);
+    job->Start();
+    return Handle();
+  }
+  return queue_.Move(handle, priority);

[mmenke, 2011/12/21 16:22:58]

I think it might be a little simpler, and not all that much more inefficient to
just get rid of Move, and use Erase/Add instead.  The only downside is you'd
need to check at a higher level if the priority is unchanged.

If you prefer it as it is, that's fine, just a suggestion.

[szym, 2011/12/28 01:24:10]

Agreed. "Move" would make more sense if it preserved insertion order. Right now
it's only saving one heap alloc and free for the std::list node.

Done.

+}
+
+void PriorityDispatch::OnJobFinished() {
+  DCHECK_GT(num_running_jobs_, 0u);
+  --num_running_jobs_;
+  Handle handle = queue_.First();
+  if (handle.is_null()) {
+    DCHECK_EQ(0u, queue_.size());
+    return;
+  }
+  if (num_running_jobs_ < max_running_jobs_[handle.priority()]) {
+    Job* job = handle.value();
+    queue_.Erase(handle);
+    ++num_running_jobs_;
+    DCHECK(job);
+    job->Start();
+  }
+}
+
+}  // namespace net
+
+